Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic Persisted Queries #1097

Closed
wants to merge 2 commits into from
Closed

Automatic Persisted Queries #1097

wants to merge 2 commits into from

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Apr 16, 2022

@ardatan ardatan changed the title Persisted Queries Generic Persisted Queries Apr 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2022

The latest changes of this PR are available as canary in npm (based on the declared changesets):

@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 199276      ✗ 0    
     data_received..................: 23 MB   777 kB/s
     data_sent......................: 12 MB   382 kB/s
     http_req_blocked...............: avg=1.35µs   min=800ns   med=1.1µs   max=3.37ms  p(90)=1.6µs   p(95)=1.9µs   
     http_req_connecting............: avg=14ns     min=0s      med=0s      max=1.49ms  p(90)=0s      p(95)=0s      
   ✓ http_req_duration..............: avg=219.49µs min=136.1µs med=196.5µs max=18.17ms p(90)=256.5µs p(95)=289.82µs
       { expected_response:true }...: avg=219.49µs min=136.1µs med=196.5µs max=18.17ms p(90)=256.5µs p(95)=289.82µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 99638
     http_req_receiving.............: avg=19.86µs  min=10.6µs  med=18.2µs  max=7.46ms  p(90)=25.1µs  p(95)=27.6µs  
     http_req_sending...............: avg=8.51µs   min=4.2µs   med=6µs     max=4.25ms  p(90)=11.4µs  p(95)=12.3µs  
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s      
     http_req_waiting...............: avg=191.12µs min=119.4µs med=170.8µs max=17.85ms p(90)=225.3µs p(95)=256.3µs 
     http_reqs......................: 99638   3321.061296/s
     iteration_duration.............: avg=294.56µs min=194.5µs med=268.6µs max=18.42ms p(90)=346.1µs p(95)=377.01µs
     iterations.....................: 99638   3321.061296/s
     vus............................: 1       min=1         max=1  
     vus_max........................: 1       min=1         max=1  

Copy link
Owner

@dotansimha dotansimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ardatan I wonder if this could be implemented as envelop plugin? 🤔

@ardatan
Copy link
Collaborator Author

ardatan commented Apr 25, 2022

@dotansimha No I don't think so this has nothing to do with Envelop. The logic is done immediately after HTTP Request is parsed into a GraphQL Parameters object.

@n1ru4l
Copy link
Collaborator

n1ru4l commented Apr 25, 2022

@dotansimha See #1038 IMHO this should be a plugin for the extended plugin system..

@ardatan
Copy link
Collaborator Author

ardatan commented Apr 26, 2022

Closing in favor of #1137

@ardatan ardatan closed this Apr 26, 2022
@ardatan ardatan deleted the persisted-queries branch June 5, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants