Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored forms and responses #333

Merged
merged 12 commits into from
Feb 17, 2025
Merged

Refactored forms and responses #333

merged 12 commits into from
Feb 17, 2025

Conversation

MarioRadu
Copy link
Member

No description provided.

@MarioRadu MarioRadu linked an issue Feb 14, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Feb 14, 2025

Qodana for PHP

6 new problems were found

Inspection name Severity Problems
ESLint 🔴 Failure 4
Exception used for local control-flow 🔶 Warning 1
Unused local symbol 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 114 dependencies

Third-party software list

This page lists the third-party software dependencies used in project

Dependency Version Licenses
brick/math 0.12.1 MIT
brick/varexporter 0.5.0 MIT
composer/ca-bundle 1.5.5 MIT
doctrine/collections 2.2.2 MIT
doctrine/common 3.5.0 MIT
doctrine/data-fixtures 2.0.2 MIT
doctrine/dbal 4.2.2 MIT
doctrine/deprecations 1.1.4 MIT
doctrine/event-manager 2.0.1 MIT
doctrine/inflector 2.0.10 MIT
doctrine/instantiator 2.0.0 MIT
doctrine/lexer 3.0.1 MIT
doctrine/migrations 3.8.2 MIT
doctrine/orm 3.3.2 MIT
doctrine/persistence 3.4.0 MIT
dotkernel/dot-authentication 2.5.1 MIT
dotkernel/dot-authorization 3.6.1 MIT
dotkernel/dot-cache 4.2.1 MIT
dotkernel/dot-cli 3.8.1 MIT
dotkernel/dot-controller 3.5.1 MIT
dotkernel/dot-data-fixtures 1.3.1 MIT
dotkernel/dot-dependency-injection 1.1.1 MIT
dotkernel/dot-errorhandler 4.0.0 MIT
dotkernel/dot-event 3.4.2 MIT
dotkernel/dot-flashmessenger 3.5.0 MIT
dotkernel/dot-geoip 3.8.1 MIT
dotkernel/dot-helpers 3.7.1 MIT
dotkernel/dot-log 4.0.4 MIT
dotkernel/dot-mail 5.1.3 MIT
dotkernel/dot-navigation 3.5.1 MIT
dotkernel/dot-rbac-guard 3.5.0 MIT
dotkernel/dot-rbac 3.6.0 MIT
dotkernel/dot-session 5.6.0 MIT
dotkernel/dot-twigrenderer 3.4.3 MIT
egulias/email-validator 4.0.3 MIT
fig/http-message-util 1.1.5 MIT
friendsofphp/proxy-manager-lts v1.0.18 MIT
geoip2/geoip2 v3.1.0 Apache-2.0
guzzlehttp/guzzle 7.9.2 MIT
guzzlehttp/promises 2.0.4 MIT
guzzlehttp/psr7 2.7.0 MIT
laminas/laminas-authentication 2.16.0 BSD-3-Clause
laminas/laminas-cli 1.11.0 BSD-3-Clause
laminas/laminas-code 4.16.0 BSD-3-Clause
laminas/laminas-component-installer 3.5.0 BSD-3-Clause
laminas/laminas-config-aggregator 1.17.0 BSD-3-Clause
laminas/laminas-diactoros 3.5.0 BSD-3-Clause
laminas/laminas-escaper 2.15.0 BSD-3-Clause
laminas/laminas-eventmanager 3.14.0 BSD-3-Clause
laminas/laminas-filter 2.40.0 BSD-3-Clause
laminas/laminas-form 3.21.0 BSD-3-Clause
laminas/laminas-httphandlerrunner 2.11.0 BSD-3-Clause
laminas/laminas-hydrator 4.16.0 BSD-3-Clause
laminas/laminas-i18n 2.29.0 BSD-3-Clause
laminas/laminas-inputfilter 2.31.0 BSD-3-Clause
laminas/laminas-json 3.7.1 BSD-3-Clause
laminas/laminas-math 3.8.1 BSD-3-Clause
laminas/laminas-permissions-rbac 3.7.0 BSD-3-Clause
laminas/laminas-servicemanager 3.23.0 BSD-3-Clause
laminas/laminas-session 2.24.0 BSD-3-Clause
laminas/laminas-stdlib 3.20.0 BSD-3-Clause
laminas/laminas-stratigility 3.13.0 BSD-3-Clause
laminas/laminas-translator 1.1.0 BSD-3-Clause
laminas/laminas-validator 2.64.2 BSD-3-Clause
laminas/laminas-view 2.36.0 BSD-3-Clause
maxmind-db/reader v1.12.0 Apache-2.0
maxmind/web-service-common v0.10.0 Apache-2.0
mezzio/mezzio-authentication 1.10.0 BSD-3-Clause
mezzio/mezzio-authorization-rbac 1.8.0 BSD-3-Clause
mezzio/mezzio-authorization 1.10.0 BSD-3-Clause
mezzio/mezzio-cors 1.13.0 BSD-3-Clause
mezzio/mezzio-fastroute 3.12.0 BSD-3-Clause
mezzio/mezzio-helpers 5.17.0 BSD-3-Clause
mezzio/mezzio-router 3.18.0 BSD-3-Clause
mezzio/mezzio-template 2.11.0 BSD-3-Clause
mezzio/mezzio-twigrenderer 2.17.0 BSD-3-Clause
mezzio/mezzio 3.20.1 BSD-3-Clause
nikic/fast-route v1.3.0 BSD-3-Clause
nikic/php-parser v5.4.0 BSD-3-Clause
psr/cache 3.0.0 MIT
psr/container 1.1.2 MIT
psr/event-dispatcher 1.0.0 MIT
psr/http-client 1.0.3 MIT
psr/http-factory 1.1.0 MIT
psr/http-message 2.0 MIT
psr/http-server-handler 1.0.2 MIT
psr/http-server-middleware 1.0.2 MIT
psr/log 3.0.2 MIT
ralouphie/getallheaders 3.0.3 MIT
ramsey/collection 2.0.0 MIT
ramsey/uuid-doctrine 2.1.0 MIT
ramsey/uuid 4.7.6 MIT
roave/psr-container-doctrine 5.2.2 BSD-2-Clause
symfony/cache-contracts v3.5.1 MIT
symfony/cache v7.2.3 MIT
symfony/console v7.2.1 MIT
symfony/deprecation-contracts v3.5.1 MIT
symfony/event-dispatcher-contracts v3.5.1 MIT
symfony/event-dispatcher v7.2.0 MIT
symfony/filesystem v7.2.0 MIT
symfony/mailer v7.1.6 MIT
symfony/mime v7.2.3 MIT
symfony/polyfill-ctype v1.31.0 MIT
symfony/polyfill-intl-grapheme v1.31.0 MIT
symfony/polyfill-intl-idn v1.31.0 MIT
symfony/polyfill-intl-normalizer v1.31.0 MIT
symfony/polyfill-mbstring v1.31.0 MIT
symfony/service-contracts v3.5.1 MIT
symfony/stopwatch v7.2.2 MIT
symfony/string v7.2.0 MIT
symfony/var-exporter v7.2.0 MIT
twig/twig v3.20.0 BSD-3-Clause
webimpress/safe-writer 2.2.0 BSD-2-Clause
webmozart/assert 1.11.0 MIT
Contact Qodana team

Contact us at [email protected]

@arhimede
Copy link
Member

Got error 'PHP message: PHP Fatal error: Uncaught Error: Class "AdminTest\Common\TestMode" not found in /var/www/vhosts/admin5.dotkernel.net/httpdocs/config/autoload/local.test.php

@alexmerlin
Copy link
Member

Got error 'PHP message: PHP Fatal error: Uncaught Error: Class "AdminTest\Common\TestMode" not found in /var/www/vhosts/admin5.dotkernel.net/httpdocs/config/autoload/local.test.php

You probably composer installed the dependencies with the --no-dev flag and have development disabled, but have config/autoload/local.test.php duplicated from config/autoload/local.test.php.dist which should not exist on production.

Copy link
Member

@alexmerlin alexmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we still have FontAwesome icons in the repo, why change the UI icons from FontAwesome to the Themify ones?

Signed-off-by: MarioRadu <[email protected]>
@MarioRadu
Copy link
Member Author

If we still have FontAwesome icons in the repo, why change the UI icons from FontAwesome to the Themify ones?

We had bootstrap icons too (removed now) and aimed to have only 1 icon provider but Themify doesn't have a lot of options for icons and ended up using Themify where possible and the rest of them are from FontAwesome. Felt like Themify had a more 'familiar' feeling and belong to our adminator theme I guess.

@arhimede arhimede merged commit 97bcb71 into 6.0 Feb 17, 2025
13 of 16 checks passed
@alexmerlin alexmerlin deleted the issue-326 branch February 17, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Simplification: remove boostrap table
3 participants