如果源代码包被目标项目引用了，打出的目标项目的源代码包将会包含引用依赖 #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterlv
reviewed
Jun 16, 2020
| var isPrivateAssetsAll = privateAssets.Contains("all"); | ||
|
|
||
| // 解决 https://github.com/dotnet-campus/SourceYard/issues/60 | ||
| // 即使有某个包标记了使用 private asset 是 All 的，但是这个包是一个源代码包，那么打包的时候就需要添加他的引用依赖 |
There was a problem hiding this comment.
这？似乎有争议？
争议点在于，privateassets 的包一般是控制编译的，或者是分析器。可能有的不能识别非项目目录下的？
There was a problem hiding this comment.
是的，现在是源代码包标记的，即使写了 PrivateAssets 是 All 也会被添加引用
Open
walterlv
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #60