Ctor service injection #31927
Merged
Ctor service injection #31927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danroth27
reviewed
Feb 28, 2024
Co-authored-by: Daniel Roth <[email protected]>
Primary ctors work fine 👍 |
danroth27
reviewed
Feb 28, 2024
danroth27
reviewed
Feb 28, 2024
danroth27
reviewed
Feb 28, 2024
danroth27
reviewed
Feb 28, 2024
|
@danroth27 ... Your suggestion condensed all of this coverage nicely. |
|
@danroth27 ... I need to merge this to unblock other work. Now that the example components are removed from the sample apps, the build system flakes out on any other branch that I try to build. Let me know what else you see here for a fix ... and @javiercn and @mkArtakMSFT as well ... I'll patch it up. The What's New content is next after #31918 is merged, and I'll ping u offline when that's live with the link. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31926
Addresses #31909
❓ I'm not quite on the preview bits to test yet ... but I will be soon. Per the primary ctor guidance, primary ctors seem like they'll be OK here. Are they 👍 or 👎 for this?
Internal previews