-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map Static Assets updates #34009
Map Static Assets updates #34009
Conversation
@@ -20,7 +20,7 @@ Files can be downloaded from the app's own static assets or from any other locat | |||
|
|||
:::moniker range=">= aspnetcore-9.0" | |||
|
|||
* ASP.NET Core apps use Map Static Assets Middleware or Static File Middleware to serve files to clients of server-side apps. For more information, see <xref:blazor/fundamentals/static-files>. | |||
* ASP.NET Core apps use Map Static Assets routing endpoint conventions or Static File Middleware to serve files to clients of server-side apps. For more information, see <xref:blazor/fundamentals/static-files>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This level of detail seems unnecessary here. Does the reader really need to know that there are two ways to serve static files from an ASP.NET Core app (an older one and a newer one) when learning how to download a file? Consider removing these two bullet points and just making the "static assets" text above the link to the static files article.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rick-Anderson Much of this content is generic to any ASP.NET Core app that uses static files, whether it uses Blazor or not, so I'd like to consolidate it into the top-level static files article, including generic concerns like how to set up a script import map, or how to refer to the fingerprinted files. Any Blazor specific concerns related to static files can stay here.
Fixes #34008
Addresses #34002
Follow-up to #34004
Internal previews