Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Static Assets updates #34009

Merged
merged 6 commits into from
Nov 5, 2024
Merged

Map Static Assets updates #34009

merged 6 commits into from
Nov 5, 2024

Conversation

@guardrex guardrex merged commit 70cc81b into main Nov 5, 2024
3 checks passed
@guardrex guardrex deleted the guardrex/blazor-map-static-assets branch November 5, 2024 14:27
@@ -20,7 +20,7 @@ Files can be downloaded from the app's own static assets or from any other locat

:::moniker range=">= aspnetcore-9.0"

* ASP.NET Core apps use Map Static Assets Middleware or Static File Middleware to serve files to clients of server-side apps. For more information, see <xref:blazor/fundamentals/static-files>.
* ASP.NET Core apps use Map Static Assets routing endpoint conventions or Static File Middleware to serve files to clients of server-side apps. For more information, see <xref:blazor/fundamentals/static-files>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This level of detail seems unnecessary here. Does the reader really need to know that there are two ways to serve static files from an ASP.NET Core app (an older one and a newer one) when learning how to download a file? Consider removing these two bullet points and just making the "static assets" text above the link to the static files article.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rick-Anderson Much of this content is generic to any ASP.NET Core app that uses static files, whether it uses Blazor or not, so I'd like to consolidate it into the top-level static files article, including generic concerns like how to set up a script import map, or how to refer to the fingerprinted files. Any Blazor specific concerns related to static files can stay here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map Static Assets isn't middleware
2 participants