Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IHostingStartup topic #4908

Merged
merged 3 commits into from
Dec 9, 2017
Merged

IHostingStartup topic #4908

merged 3 commits into from
Dec 9, 2017

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Dec 1, 2017 •
edited
Loading

@guardrex guardrex changed the title IHostingStartup topic [WIP] IHostingStartup topic Dec 1, 2017
@guardrex
IHostingStartup topic
cb6dec7 
Updates

Updates

Updates

Updates
@guardrex guardrex changed the title [WIP] IHostingStartup topic IHostingStartup topic Dec 8, 2017
@guardrex
Copy link
Collaborator Author

guardrex commented Dec 8, 2017

@pakrym @Tratcher Let's TAL 👓 whenever ur ready and see how this is shaping up.

Notes:

  • Not a huge fan of the title ... and I wrote it! 😀 Idears?
  • Uses a build target approach with a PS script to move files and mod the deps file. Script works on Win and Mac, but I can only confirm that the whole process works on Win. My 2009 Mac Mini can't take Sierra, so it can't take 2.0, so it can't really test this approach adequately for Mac. I did this to automate the sample as much as possible to avoid having to wrap the IHostingStartup project and trim the deps file. See if my approach is sane here. Vegas puts the odds at 50-50 that it's ok. 😄
  • I addressed the feedback in Document IHostStartup (host lightup feature) #4438.

guardrex
guardrex commented Dec 8, 2017
View reviewed changes
aspnetcore/hosting/ihostingstartup.md Outdated
@@ -85,7 +85,7 @@ For global use, place the file in the `additonalDeps` folder of the .NET Core in
<DRIVE>\Program Files\dotnet\additionalDeps\<FEATURE_ASSEMBLY_NAME>\shared\Microsoft.NETCore.App\2.0.0\
```

Note that the version, `2.0.0`, reflects the version of the shared runtime that the target app uses (the shared runtime listed in *\*.runtimeconfig.json*). In the sample app, the shared runtime is specified in the *HostingStartupSample.runtimeconfig.json* file.
Note the version, `2.0.0`, reflects the version of the shared runtime that the target app uses. The shared runtime listed in *\*.runtimeconfig.json*. In the sample app, the shared runtime is specified in the *HostingStartupSample.runtimeconfig.json* file.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing "is"? ... perhaps with "file" and a def article:

The shared runtime is shown in the *\*.runtimeconfig.json* file.

Rick-Anderson
Rick-Anderson approved these changes Dec 8, 2017
View reviewed changes
Copy link
Contributor

@Rick-Anderson Rick-Anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as a dev has signed off.

aspnetcore/hosting/ihostingstartup.md Outdated

[!code-xml[Main](ihostingstartup/snapshot_sample/StartupFeature.csproj)]

A [HostingStartupAttribute](/dotnet/api/microsoft.aspnetcore.hosting.hostingstartupattribute) identifies a class as an implementation of `IHostingStartup` for loading and execution when building the [IWebHost](/dotnet/api/microsoft.aspnetcore.hosting.iwebhost). In the following example, the namespace is `StartupFeature`, and the class is `StartupFeatureHostingStartup`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A [HostingStartup](/dotnet/api/microsoft.aspnetcore.hosting.hostingstartupattribute) attribute identifies a class as an implementation

A HostingStartup attribute identifies a class as an implementation

We usually write attributes that way give that's how they're used in code.

@guardrex
Copy link
Collaborator Author

guardrex commented Dec 8, 2017

LGTM as long as a dev has signed off.

We need a real programmer to look at my dino hacks 🦎 on this one. 😄

@Rick-Anderson Rick-Anderson merged commit 1e1f3e6 into dotnet:master Dec 9, 2017
@guardrex guardrex deleted the ihostingstartup-topic branch December 9, 2017 01:17
@guardrex guardrex restored the ihostingstartup-topic branch December 9, 2017 01:18
@guardrex
Copy link
Collaborator Author

guardrex commented Dec 9, 2017 •
edited
Loading

@Rick-Anderson This wasn't signed-off by an engineering team member ... did they verbally say it was 'ok'? 😄 I'd sleep better if they look 👁️.

Rick-Anderson added a commit that referenced this pull request Dec 9, 2017
@Rick-Anderson
Revert "IHostingStartup topic (#4908)"
75d0319 
This reverts commit 1e1f3e6.
@Rick-Anderson Rick-Anderson mentioned this pull request Dec 9, 2017
Merged
Rick-Anderson added a commit that referenced this pull request Dec 9, 2017
@Rick-Anderson
Revert "IHostingStartup topic" (#4957)
38fafd6 
* Revert "Add IStartupFilter coverage to App Startup topic with UE pass (#4878)"

This reverts commit 1daa4ac.

* Revert "IHostingStartup topic (#4908)"

This reverts commit 1e1f3e6.
@Tratcher
Copy link
Member

Sorry I didn't get to this last week, I'm out of the office a lot this month.

The content here is primarily focused on implementers, it doesn't cover any of the consumer mechanics. We get a lot of questions from folks about how to control and debug this injection process and I think we should add that information here. See this thread dotnet/aspnetcore#2051

@guardrex guardrex deleted the ihostingstartup-topic branch December 11, 2017 17:58
@guardrex guardrex restored the ihostingstartup-topic branch December 11, 2017 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rick-Anderson Rick-Anderson Rick-Anderson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guardrex @Tratcher @Rick-Anderson