changed PresetTextWrap to PresetTextWarp #1448
Conversation
There was a problem hiding this comment.
I think this was generated without the fix for #1444, which is needed before merging.
| @@ -5023,7 +5023,7 @@ | |||
| }, | |||
| { | |||
| "QName": ":custScaleY", | |||
| "PropertyName": "HeightScale", | |||
| "PropertyName": "HightScale", | |||
There was a problem hiding this comment.
Is this undoing the fix from #1444 ?
| @@ -4542,7 +4542,7 @@ public static class NoNamespace | |||
| /// <para>As an XML attribute, it:</para> | |||
| /// <list type="bullet"> | |||
| /// <item><description>is contained in the following XML elements: <see cref="DGM.prSet" />.</description></item> | |||
| /// <item><description>corresponds to the following strongly-typed properties: PropertySet.HeightScale.</description></item> | |||
| /// <item><description>corresponds to the following strongly-typed properties: PropertySet.HightScale.</description></item> | |||
There was a problem hiding this comment.
Same question about #1444
| @@ -6910,7 +6910,7 @@ public PropertySet(string outerXml) : base(outerXml) | |||
| /// <para>Height Scale</para> | |||
| /// <para>Represents the following attribute in the schema: custScaleY</para> | |||
| /// </summary> | |||
| public Int32Value? HeightScale | |||
| public Int32Value? HightScale | |||
There was a problem hiding this comment.
conflict with fix for #1444
| @@ -7020,7 +7020,7 @@ internal override void ConfigureMetadata(ElementMetadata.Builder builder) | |||
| .AddAttribute("custSzX", a => a.FixedWidthOverride) | |||
| .AddAttribute("custSzY", a => a.FixedHeightOverride) | |||
| .AddAttribute("custScaleX", a => a.WidthScale) | |||
| .AddAttribute("custScaleY", a => a.HeightScale) | |||
| .AddAttribute("custScaleY", a => a.HightScale) | |||
yup, you're right. It's because 1444 didn't get merged on the backend. I'll take care of that and it will fix this when I remerge everything. Also, this doesn't get caught by the tests, otherwise, it would not have made it this far. Maybe we should look into a test that covers more of the API surface to catch stuff like this. |
|
@mikeebowen Ok, HeightScale fix is now included. |
|
/azp run |
|
No pipelines are associated with this pull request. |
yeah, we discussed this and we should do it anyway, but the problem is that things like "warp" to "wrap" don't trigger spell checkers. I'll give it a scan anyway. |
|
I did a spell check scan on the front end code (non-generated) and found mostly comment spelling issues with only a couple code issues. |
|
@tomjebo you'll need move the branch to the dotnet fork instead of yours until you get the GH actions working |
Ah, ok. I'll move this over to a new dotnet branch. |
|
@tomjebo can this be closed? |
No description provided.