Implement SqlConnection.GetSchemaAsync #3005
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
reviewed
Nov 14, 2024
src/Microsoft.Data.SqlClient/src/Microsoft/Data/ProviderBase/DbMetaDataFactory.cs
Outdated
Show resolved
Hide resolved
| @@ -107,7 +109,7 @@ protected virtual void Dispose(bool disposing) | |||
| } | |||
| } | |||
|
|
|||
| private DataTable ExecuteCommand(DataRow requestedCollectionRow, string[] restrictions, DbConnection connection) | |||
| private async ValueTask<DataTable> ExecuteCommandAsync(DataRow requestedCollectionRow, string[] restrictions, DbConnection connection, bool isAsync, CancellationToken cancellationToken) | |||
There was a problem hiding this comment.
Really nice to be seeing proper async/await in SqlClient!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3005 +/- ##
==========================================
+ Coverage 72.48% 72.53% +0.04%
==========================================
Files 288 288
Lines 59493 59519 +26
==========================================
+ Hits 43123 43170 +47
+ Misses 16370 16349 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
edwardneal
changed the title
This introduces async-over-sync, removing such requires work with the state machine and separate review.
edwardneal
changed the title
mdaigle
added
💡 Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #646, adding
SqlConnection.GetSchemaAsync.I can't add the IDbColumnSchemaGenerator method because the .NET Framework version of SqlDataReader doesn't yet implement that interface. #2967 tracks this.
SqlDataReader.GetSchemaTableAsyncrequires some extra work with the state machine to guarantee that the column metadata is available, and I'll submit a separate PR for this.I've added some basic documentation, but this effectively follows the
SqlCommand.[Something]Asyncpattern of "An asynchronous version of [Something], which <etc.>"I've also moved the netfx GetSchema methods from SqlConnectionHelper.cs to SqlConnection.cs, to align that part of it with netcore. This contributes to the merge slightly.