[Xamarin.Android.Build.Tasks] Rework AndroidApkSigner to use .jar directly. #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectly. Once again we hit an issue where the `apksigner.bat` file provided with android build-tools was not functioning correctly. So like we did with `dx.bat` and other tooling we should switch to using the `apksigner.jar` file directly. Additionally JDK 9 has removed support for the `java.ext.dirs`, which all versions of the `apksigner.bat` use. As a result this tool will not work with JDK 9. So its best to remove it now. We have existing unit tests which check that the Apk is being signed correctly. So not additional tests are required.
dellis1972
added
the
Area: App+Library Build
jonpryor
reviewed
Jan 24, 2018
| ApkToSign="$(ApkFileSigned)" | ||
| KeyStore="$(_ApkKeyStore)" | ||
| KeyAlias="$(_ApkKeyAlias)" | ||
| KeyPass="$(_ApkKeyPass)" | ||
| StorePass="$(_ApkStorePass)" | ||
| ToolPath="$(AndroidSdkBuildToolsBinPath)" | ||
| ToolExe="$(ApkSignerToolExe)" | ||
| ToolPath="$(JavacToolPath)" |
There was a problem hiding this comment.
I believe that this should be $(JavaToolPath), and the following line $(JavaToolExe), not Javac.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Aug 26, 2021
Changes: xamarin/monodroid@fb0d502...5676b84 * xamarin/monodroid@5676b84b4: Bump to xamarin/androidtools@0abc0d7c (dotnet#1223) * xamarin/monodroid@daf1aa909: [optimization] Replace 'new T[0]' with 'Array.Empty<T> ()' to reduce allocations. (dotnet#1221) * xamarin/monodroid@fb848118b: [tools/msbuild] Check `device.Properties.BuildVersionSdk` for `-1` (dotnet#1222) * xamarin/monodroid@489a389d1: [tools/msbuild] Check device additional output to see if its the same device. (dotnet#1218) * xamarin/monodroid@209a7c352: [tests/AndroidMSBuildTests] Remove Unused Unit Tests (dotnet#1215)
jonpryor
added a commit
that referenced
this pull request
Aug 27, 2021
Changes: xamarin/monodroid@fb0d502...5676b84 * xamarin/monodroid@5676b84b4: Bump to xamarin/androidtools@0abc0d7c (#1223) * xamarin/monodroid@daf1aa909: [optimization] Replace 'new T[0]' with 'Array.Empty<T> ()' to reduce allocations. (#1221) * xamarin/monodroid@fb848118b: [tools/msbuild] Check `device.Properties.BuildVersionSdk` for `-1` (#1222) * xamarin/monodroid@489a389d1: [tools/msbuild] Check device additional output to see if its the same device. (#1218) * xamarin/monodroid@209a7c352: [tests/AndroidMSBuildTests] Remove Unused Unit Tests (#1215)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once again we hit an issue where the
apksigner.batfile providedwith android build-tools was not functioning correctly. So like
we did with
dx.batand other tooling we should switch to usingthe
apksigner.jarfile directly.Additionally JDK 9 has removed support for the
java.ext.dirs, whichall versions of the
apksigner.batuse. As a result this tool willnot work with JDK 9. So its best to remove it now.
We have existing unit tests which check that the Apk is being
signed correctly. So not additional tests are required.