[d17-5] [Xamarin.Android.Build.Tasks] allow JDK 17 usage

[jonathanpeppers]

Context: #8309
Context: https://learn.microsoft.com/java/openjdk/download#openjdk-17

Classic Xamarin.Android apps appear to work with JDK-17, just by doing:

msbuild -r -bl -t:SignAndroidPackage -p:JavaSdkDirectory="C:\Program Files\Microsoft\jdk-17.0.8.101-hotspot" -p:LatestSupportedJavaVersion=17.99

I see log messages calling a JDK 17 javac like:

_CompileJava:
C:\Program Files\Microsoft\jdk-17.0.8.101-hotspot\bin\javac.exe -J-Dfile.encoding=UTF8 "@C:\Users\jopepper\AppData\Local\Temp\tmp119C.tmp" -target 1.8 -source 1.8

Update $(LatestSupportedJavaVersion) to allow usage of JDK 17.

[jonathanpeppers]

There is one test failure:

obj\Release should have no files.
Expected: <empty>
But was:  < "C:\a_work\1\a\TestRelease\08-31_17.47.23\temp\CleanBasicBindingLibraryclass-parse\obj\Release_XamarinBuildIsIncremental" >

This looks to be caused by a .targets file from XamarinVS:

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Xamarin\Xamarin.Sdk.targets

https://github.com/xamarin/XamarinVS/blob/main/src/MSBuild/Xamarin/Xamarin.Sdk.targets

<_XamarinBuildIsIncrementalFile>$(IntermediateOutputPath)\_XamarinBuildIsIncremental</_XamarinBuildIsIncrementalFile>
...
<WriteLinesToFile Lines="$(_XamarinBuildIsIncrementalFile)" File="$(_XamarinBuildIsIncrementalFile)" Condition="!Exists('$(_XamarinBuildIsIncrementalFile)')" ContinueOnError="true" />

The target seems questionable (would have benefitted from our code review), but I don't think .NET 6+ even imports this file, so we can probably ignore it?

[jonpryor]

@jonathanpeppers: the CleanBasicBindingLibrary("class-parse") is a "known bad" test and has been failing with that error for quite some time, e.g. from 7557f5d: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8199578&view=ms.vss-test-web.build-test-results-tab&runId=81691700&resultId=100097&paneView=history

obj\Release should have no files.
Expected: <empty>
But was:  < "C:\a_work\1\a\TestRelease\08-04_01.23.34\temp\CleanBasicBindingLibraryclass-parse\obj\Release_XamarinBuildIsIncremental" >

We can totally ignore this failure.