[Xamarin.Android.Build.Tasks] Remove "Xamarin" from messages #8884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://dotnet.microsoft.com/platform/support/policy/xamarin Context: ab3773c Support for Xamarin.Android ends on 2024-May-1. Update error and warning messages to minimize use of "Xamarin". Remaining messages which contain "xamarin" are: * XA0030: Building with JDK version `{0}` is not supported. Please install JDK version `{1}`. See https://aka.ms/xamarin/jdk9-errors * XA1005: If basic type name matching fails, please add a `xamarin:managedType` attribute to the element to specify the fully qualified managed type name of the element XA0030 Should Not Happen with .NET 6+, as JDK 11+ is required. XA0030 is thus moot. XA1005 is related to Layout Code Behind (ab3773c), and replacing `xamarin` would (1) be a source breaking change (so we can't *remove* support for `xamarin`), and (2) while we could add an alternate XML namespace to use for layout code behind, that's a larger change.
| @@ -118,7 +118,7 @@ | |||
| <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value> | |||
| </resheader> | |||
| <data name="XA2000" xml:space="preserve"> | |||
| <value>Use of AppDomain.CreateDomain() detected in assembly: {0}. .NET 6 and higher will only support a single AppDomain, so this API will no longer be available in Xamarin.Android once .NET 6 is released.</value> | |||
| <value>Use of AppDomain.CreateDomain() detected in assembly: {0}. .NET 6 and higher will only support a single AppDomain, so this API will is no longer be available.</value> | |||
There was a problem hiding this comment.
I think there is a typo, maybe it should be something like:
Suggested change
| <value>Use of AppDomain.CreateDomain() detected in assembly: {0}. .NET 6 and higher will only support a single AppDomain, so this API will is no longer be available.</value> | |
| <value>Use of AppDomain.CreateDomain() detected in assembly: {0}. .NET 6 and higher will only support a single AppDomain, so this API is no longer available.</value> |
dellis1972
reviewed
Apr 19, 2024
| @@ -562,11 +562,11 @@ Either change the value in the AndroidManifest.xml to match the $(SupportedOSPla | |||
| {0} - The assembly name</comment> | |||
| </data> | |||
| <data name="APT2264" xml:space="preserve"> | |||
| <value>This could be caused by the project exceeding the Windows maximum path length limitation. See https://learn.microsoft.com/xamarin/android/errors-and-warnings/apt2264 for details.</value> | |||
| <value>This could be caused by the project exceeding the Windows maximum path length limitation. See https://learn.microsoft.com/en-us/dotnet/android/messages/apt2264 for details.</value> | |||
There was a problem hiding this comment.
We should not use the en-us bit in the url. Otherwise it won't redirect to the culture specific page once the translations are done.
There was a problem hiding this comment.
dellis1972
reviewed
Apr 19, 2024
| <comment>The following are literal names and should not be translated:</comment> | ||
| </data> | ||
| <data name="APT2265" xml:space="preserve"> | ||
| <value>This could be caused by the project having non-ASCII characters in its filename or path. See https://learn.microsoft.com/xamarin/android/errors-and-warnings/apt2265 for details.</value> | ||
| <value>This could be caused by the project having non-ASCII characters in its filename or path. See https://learn.microsoft.com/en-us/dotnet/android/messages/apt2265 for details.</value> |
There was a problem hiding this comment.
ditto . https://learn.microsoft.com/dotnet/android/messages/apt2265 should work fine
jonathanpeppers
approved these changes
Apr 22, 2024
jonpryor
added a commit
that referenced
this pull request
Apr 22, 2024
Context: https://dotnet.microsoft.com/platform/support/policy/xamarin Context: ab3773c Support for Xamarin.Android ends on 2024-May-1. Update error and warning messages to minimize use of "Xamarin". Remaining messages which contain "xamarin" are: * XA0030: Building with JDK version `{0}` is not supported. Please install JDK version `{1}`. See https://aka.ms/xamarin/jdk9-errors * XA1005: If basic type name matching fails, please add a `xamarin:managedType` attribute to the element to specify the fully qualified managed type name of the element XA0030 Should Not Happen with .NET 6+, as JDK 11+ is required. XA0030 is thus moot. XA1005 is related to Layout Code Behind (ab3773c), and replacing `xamarin` would (1) be a source breaking change (so we can't *remove* support for `xamarin`), and (2) while we could add an alternate XML namespace to use for layout code behind, that's a larger change.
grendello
added a commit
that referenced
this pull request
Apr 23, 2024
* main: Bump to xamarin/xamarin-android-binutils/L_18.1.4-8.0.0@758d2e7 (#8885) [Mono.Android] Bind API-VanillaIceCream Beta 1 (#8891) [AndroidToolTask] Log tool output as error (#8861) [Xamarin.Android.Build.Tasks] Remove "Xamarin" from messages (#8884) [Mono.Android] Bind API-VanillaIceCream Developer Preview 2 (#8741) Bump to dotnet/installer@22ffa42d6c 9.0.100-preview.4.24221.5 (#8887) Bump external/xamarin-android-tools from `37d79c9` to `05f9a90` (#8869) Bump external/Java.Interop from `e1c7832` to `06214ff` (#8878) Bump to dotnet/installer@7380c301c1 9.0.100-preview.4.24215.2 (#8874) [Mono.Android] Commit baseline PublicAPI files for API-35 (#8840) Add a unit test to check environment processing (#8856) Don't use azureedge.net CDN (#8846) Bump to dotnet/installer@0bfd2dd757 9.0.100-preview.4.24208.2 (#8862) [ci] Update dependabot ignore list (#8864) Bump external/Java.Interop from `651de42` to `e1c7832` (#8836) Bumps LLVM to v18.1.3 and XA utils version to 8.0.0 (#8852)
grendello
added a commit
that referenced
this pull request
Apr 23, 2024
* main: Bump to xamarin/xamarin-android-binutils/L_18.1.4-8.0.0@758d2e7 (#8885) [Mono.Android] Bind API-VanillaIceCream Beta 1 (#8891) [AndroidToolTask] Log tool output as error (#8861) [Xamarin.Android.Build.Tasks] Remove "Xamarin" from messages (#8884) [Mono.Android] Bind API-VanillaIceCream Developer Preview 2 (#8741) Bump to dotnet/installer@22ffa42d6c 9.0.100-preview.4.24221.5 (#8887)
grendello
added a commit
that referenced
this pull request
Apr 25, 2024
* main: (26 commits) [Mono.Android] fix potential leak of RunnableImplementors (#8900) [build] Bump $(AndroidNetPreviousVersion) to 34.0.95 (#8898) [docs] Reorganize public Documentation (#8889) Bump external/Java.Interop from `06214ff` to `6cfa78c` (#8879) Localized file check-in by OneLocBuild Task (#8894) $(AndroidPackVersionSuffix)=preview.5; net9 is 34.99.0.preview.5 (#8896) Bump to xamarin/monodroid@a5742221b3 (#8893) Remove MonoArchive_BaseUri from Configurables.cs (#8890) Bump to xamarin/xamarin-android-binutils/L_18.1.4-8.0.0@758d2e7 (#8885) [Mono.Android] Bind API-VanillaIceCream Beta 1 (#8891) [AndroidToolTask] Log tool output as error (#8861) [Xamarin.Android.Build.Tasks] Remove "Xamarin" from messages (#8884) [Mono.Android] Bind API-VanillaIceCream Developer Preview 2 (#8741) Bump to dotnet/installer@22ffa42d6c 9.0.100-preview.4.24221.5 (#8887) Bump external/xamarin-android-tools from `37d79c9` to `05f9a90` (#8869) Bump external/Java.Interop from `e1c7832` to `06214ff` (#8878) Bump to dotnet/installer@7380c301c1 9.0.100-preview.4.24215.2 (#8874) [Mono.Android] Commit baseline PublicAPI files for API-35 (#8840) Add a unit test to check environment processing (#8856) Don't use azureedge.net CDN (#8846) ...
grendello
added a commit
that referenced
this pull request
May 6, 2024
* release/8.0.2xx: [Mono.Android] fix potential leak of RunnableImplementors (#8900) Bump to xamarin/monodroid@21aed734 (#8905) [Xamarin.Android.Build.Tasks] fix detection of "Android libraries" (#8904) [ci] Do not use @self annotation for templates (#8783) Bump to xamarin/xamarin-android-tools/release/8.0.1xx@d50747cb (#8892) [Xamarin.Android.Build.Tasks] Remove "Xamarin" from messages (#8884) [ci] Use NuGetAuthenticate@1 (#8877) [ci] Migrate to the 1ES template (#8876)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://dotnet.microsoft.com/platform/support/policy/xamarin
Context: ab3773c
Support for Xamarin.Android ends on 2024-May-1.
Update error and warning messages to minimize use of "Xamarin".
Remaining messages which contain "xamarin" are:
XA0030: Building with JDK version
{0}is not supported. Please install JDK version{1}. See https://aka.ms/xamarin/jdk9-errorsXA1005: If basic type name matching fails, please add a
xamarin:managedTypeattribute to the element to specify the fully qualified managed type name of the elementXA0030 Should Not Happen with .NET 6+, as JDK 11+ is required. XA0030 is thus moot.
XA1005 is related to Layout Code Behind (ab3773c), and replacing
xamarinwould (1) be a source breaking change (so we can't remove support forxamarin), and (2) while we could add an alternate XML namespace to use for layout code behind, that's a larger change.