Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AsmDiff] For attributes, move the +/- diff symbol to the attribute instead of the affected API #13814

Open
carlossanlop opened this issue Jun 15, 2023 · 0 comments
Open

[AsmDiff] For attributes, move the +/- diff symbol to the attribute instead of the affected API #13814

carlossanlop opened this issue Jun 15, 2023 · 0 comments
Labels
area-Infrastructure-libraries Area maintained by .NET libraries team: APICompat, AsmDiff, GenAPI, GenFacades, PkgProj, etc up-for-grabs

Comments

@carlossanlop
Copy link
Member

This has come up multiple times:

AsmDiff shows the API as deleted and then re-added with new attributes or with removed attributes. It's confusing. We should find a way to only show the diff +/- symbols next to the updated attribute.
@carlossanlop carlossanlop added the area-Infrastructure-libraries Area maintained by .NET libraries team: APICompat, AsmDiff, GenAPI, GenFacades, PkgProj, etc label Jun 15, 2023
This was referenced Jun 15, 2023
Merged
Merged
@carlossanlop carlossanlop mentioned this issue Jul 11, 2023
Merged
@carlossanlop carlossanlop mentioned this issue Aug 8, 2023
Merged
@carlossanlop carlossanlop mentioned this issue Sep 12, 2023
Merged
@carlossanlop carlossanlop mentioned this issue Oct 11, 2023
Merged
This was referenced Nov 15, 2023
Merged
Merged
@carlossanlop carlossanlop mentioned this issue Feb 13, 2024
Merged
@carlossanlop carlossanlop mentioned this issue Mar 12, 2024
Merged
@directhex directhex mentioned this issue Apr 11, 2024
Merged
@carlossanlop carlossanlop mentioned this issue May 21, 2024
Merged
@carlossanlop carlossanlop mentioned this issue Jun 12, 2024
Merged
@carlossanlop carlossanlop mentioned this issue Jul 10, 2024
Merged
@carlossanlop carlossanlop mentioned this issue Aug 13, 2024
Merged
@carlossanlop carlossanlop mentioned this issue Sep 10, 2024
Merged
@ericstj ericstj mentioned this issue Oct 8, 2024
Merged
This was referenced Nov 12, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Infrastructure-libraries Area maintained by .NET libraries team: APICompat, AsmDiff, GenAPI, GenFacades, PkgProj, etc up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@carlossanlop @missymessa and others