-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API diff between .NET 8 and .NET 9 #9602
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for System.Data (SqlDbType.Json)
|
release-notes/9.0/9.0.0/api-diff/Microsoft.NETCore.App/9.0.0_System.Diagnostics.md
Outdated
Show resolved
Hide resolved
+ public Measurement(T value, in TagList tags); | ||
} | ||
- public delegate void MeasurementCallback<T>(Instrument instrument, T measurement, ReadOnlySpan<KeyValuePair<string, object?>> tags, object? state); | ||
+ public delegate void MeasurementCallback<T>(Instrument instrument, T measurement, ReadOnlySpan<KeyValuePair<string, object?>> tags, object? state) where T : struct; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
release-notes/9.0/9.0.0/api-diff/Microsoft.NETCore.App/9.0.0_System.Diagnostics.Metrics.md
Show resolved
Hide resolved
I added some comments, LGTM otherwise:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linq, collections and STJ LGTM
Repo area owners:
Libraries area owners:
Known api-diff tool issues:
If yo usee any of these, please provide a GitHub suggestion in this PR to correct it:
{
or{}
arcade#10981([AsmDiff] For attributes, move the +/- diff symbol to the attribute instead of the affected API arcade#13814)protected internal
visibility should stop showing. AsmDiff: Do not show APIs withprotected internal
visibility arcade#14579