Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API diff between .NET 8 and .NET 9 #9602

Merged
merged 7 commits into from
Nov 19, 2024
Merged

Conversation

carlossanlop
Copy link
Member

Repo area owners:

Libraries area owners:

  • System @dotnet/area-system-runtime
  • System.Buffers @dotnet/area-system-buffers
  • System.CodeDom @dotnet/area-system-codedom
  • System.Collections @dotnet/area-system-collections
  • System.ComponentModel @dotnet/area-system-componentmodel
  • System.Data @SamMonoRT @ajcvickers @roji
  • System.Diagnostics @dotnet/area-system-diagnostics
  • System.Diagnostics.Metrics @dotnet/area-system-diagnostics-metric
  • System.Drawing @dotnet/area-system-drawing @JeremyKuhne
  • System.Formats.Asn1 @dotnet/area-system-formats-asn1
  • System.Formats.Nrbf @dotnet/area-system-formats-nrbf
  • System.Formats.Tar @dotnet/area-system-formats-tar
  • System.IO @dotnet/area-system-io
  • System.IO.Compression @dotnet/area-system-io-compression
  • System.IO.Pipelines @adityamandaleeka @davidfowl @halter73
  • System.IO.Pipes @dotnet/area-system-io
  • System.IO.Ports @dotnet/area-system-io-ports
  • System.Linq @dotnet/area-system-linq
  • System.Management @dotnet/area-system-management
  • System.Memory @dotnet/area-system-memory
  • System.Net @dotnet/ncl
  • System.Numerics @dotnet/area-system-numerics @dotnet/area-system-numerics-tensors
  • System.Reflection @dotnet/area-system-reflection @dotnet/area-system-reflection-emit @dotnet/area-system-reflection-metadata
  • System.Runtime.CompilerServices @dotnet/area-system-runtime-compilerservices
  • System.Runtime.InteropServices @dotnet/interop-contrib
  • System.Runtime.Intrinsics @dotnet/area-system-runtime-intrinsics
  • System.Security @dotnet/area-system-security
  • System.Text @dotnet/area-system-text-encoding
  • System.Text.Json @dotnet/area-system-text-json
  • System.Threading @dotnet/area-system-threading-channels @dotnet/area-system-threading-tasks @kouvel @mangod9
  • System.Timers @dotnet/area-system-runtime

Known api-diff tool issues:

If yo usee any of these, please provide a GitHub suggestion in this PR to correct it:

@carlossanlop carlossanlop self-assigned this Nov 12, 2024
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for System.Data (SqlDbType.Json)

@bartonjs
Copy link
Member

  • System.Formats.Asn1 LGTM
  • System.Security.* LGTM

+ public Measurement(T value, in TagList tags);
}
- public delegate void MeasurementCallback<T>(Instrument instrument, T measurement, ReadOnlySpan<KeyValuePair<string, object?>> tags, object? state);
+ public delegate void MeasurementCallback<T>(Instrument instrument, T measurement, ReadOnlySpan<KeyValuePair<string, object?>> tags, object? state) where T : struct;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarekgh
Copy link
Member

tarekgh commented Nov 12, 2024

I added some comments, LGTM otherwise:

  • System.Diagnostics (Activity and ActivitySource)
  • System.Diagnostics.Meterics
  • System.Environment.CpuUsage/ProcessCpuUsage
  • System.TimeSpan
  • Microsoft.Extensions.Logging.Abstractions.BufferedLogRecord/IBufferedLogger

Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linq, collections and STJ LGTM

@carlossanlop carlossanlop merged commit 5b462cf into dotnet:main Nov 19, 2024
2 of 3 checks passed
@carlossanlop carlossanlop deleted the ApiDiff8_9 branch November 19, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants