Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(angular): use provideHttpClient #101

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

timdeschryver
Copy link
Contributor

This PR updates the JavaScript Angular example to its newest API.
The HttpClientModule will soon be deprecated, and later on removed.

@IEvangelist I was allowed to ping you 😉
I'll also update the docs at https://learn.microsoft.com/en-us/dotnet/aspire/get-started/build-aspire-apps-with-nodejs next

Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we'll :shipit: - thank you 🙏

@DamianEdwards DamianEdwards merged commit 4d8865c into dotnet:main Jan 25, 2024
3 checks passed
@timdeschryver timdeschryver deleted the angular/update-httpclient branch January 26, 2024 07:36
meneasysoft pushed a commit to meneasysoft/aspire-samples that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants