Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Aspire.Hosting.Oracle.Tests #4943

Merged
merged 78 commits into from
Aug 20, 2024
Merged

Extract Aspire.Hosting.Oracle.Tests #4943

merged 78 commits into from
Aug 20, 2024

Conversation

sebastienros
Copy link
Member

@sebastienros sebastienros commented Jul 17, 2024

Contributes to #4294

Fixes #3161

Tests disabled because they don't work on the CI machines, c.f. #5362

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Jul 17, 2024
@sebastienros
Copy link
Member Author

sebastienros commented Jul 17, 2024

Based on the attempts I made to get the tested feature to work I think we should remove the features behind the two tests that are skipped there (and kept to show others what does not work IMO).

Meaning:

  • WithDataBindMount() which had issues with some passwords (special chars) and takes 5 minutes to start. (not sure it even works after that)
  • WithDbSetupBindMount() which doesn't read the files from the mount (test fails and docker logs shows the files are not taken into account). Could this be a limitation of the FREE version?

# Conflicts:
#	tests/Aspire.Hosting.Tests/Aspire.Hosting.Tests.csproj
radical and others added 5 commits July 20, 2024 01:25
@sebastienros
Copy link
Member Author

Aborting test run: test run timeout of 600000 milliseconds exceeded.

@radical tests are limited to 10 minutes apparently. Can we increase it for a test class?

@radical
Copy link
Member

radical commented Jul 22, 2024

Aborting test run: test run timeout of 600000 milliseconds exceeded.

@radical tests are limited to 10 minutes apparently. Can we increase it for a test class?

You can have a per-project .runsettings file with a higher timeout. See https://github.com/radical/aspire/blob/751ed7161f20d4c8567c95b74f04ad8096d6d34d/tests/Aspire.EndToEnd.Tests/Aspire.EndToEnd.Tests.csproj#L23
https://github.com/radical/aspire/blob/751ed7161f20d4c8567c95b74f04ad8096d6d34d/tests/Aspire.EndToEnd.Tests/.runsettings#L3-L6

@sebastienros
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sebastienros
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sebastienros sebastienros added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 17, 2024
@sebastienros sebastienros removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 20, 2024
@sebastienros
Copy link
Member Author

Disabled tests on CI since they don't work, filed an issue to track with current progress.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should be able to close #4294 when this is merged.

@sebastienros sebastienros merged commit d45778f into main Aug 20, 2024
11 checks passed
@sebastienros sebastienros deleted the sebros/oracletests branch August 20, 2024 17:59
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication testing ☑️
Projects
None yet
3 participants