-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Aspire.Hosting.Oracle.Tests #4943
Conversation
Based on the attempts I made to get the tested feature to work I think we should remove the features behind the two tests that are skipped there (and kept to show others what does not work IMO). Meaning:
|
# Conflicts: # tests/Aspire.Hosting.Tests/Aspire.Hosting.Tests.csproj
tests/Aspire.Hosting.Oracle.Tests/Aspire.Hosting.Oracle.Tests.csproj
Outdated
Show resolved
Hide resolved
# Conflicts: # Aspire.sln # tests/Aspire.EndToEnd.Tests/IntegrationServicesFixture.cs # tests/testproject/Common/TestResourceNames.cs
@radical tests are limited to 10 minutes apparently. Can we increase it for a test class? |
You can have a per-project |
tests/testproject/TestProject.IntegrationServiceA/TestProject.IntegrationServiceA.csproj
Outdated
Show resolved
Hide resolved
tests/testproject/TestProject.IntegrationServiceA/TestProject.IntegrationServiceA.csproj
Outdated
Show resolved
Hide resolved
…IntegrationServiceA.csproj Co-authored-by: Eric Erhardt <[email protected]>
Co-authored-by: Eric Erhardt <[email protected]>
Co-authored-by: Eric Erhardt <[email protected]>
…IntegrationServiceA.csproj Co-authored-by: Eric Erhardt <[email protected]>
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
6ed68e8
to
af511f0
Compare
172fcff
to
baacfe5
Compare
Disabled tests on CI since they don't work, filed an issue to track with current progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We should be able to close #4294 when this is merged.
Contributes to #4294
Fixes #3161
Tests disabled because they don't work on the CI machines, c.f. #5362
Microsoft Reviewers: Open in CodeFlow