Skip to content

Commit

Permalink
Components test parole for good behavior (#31156)
Browse files Browse the repository at this point in the history
  • Loading branch information
HaoK authored Mar 25, 2021
1 parent 1bf6332 commit 2c2df08
Show file tree
Hide file tree
Showing 10 changed files with 7 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public ServerEventTest(BrowserFixture browserFixture, ToggleExecutionModeServerF
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24688")]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/31195")]
public override void EventDuringBatchRendering_CanTriggerDOMEvents()
{
base.EventDuringBatchRendering_CanTriggerDOMEvents();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ protected override void InitializeAsyncCore()
}

[Theory]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27556")]
[InlineData("en-US")]
[InlineData("fr-FR")]
public override void CanSetCultureAndParseCultureSensitiveNumbersAndDates(string culture)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ public void BasicTestAppCanBeServed()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23366")]
public void CanRenderTextOnlyComponent()
{
var appElement = Browser.MountTestComponent<TextOnlyComponent>();
Expand Down
2 changes: 1 addition & 1 deletion src/Components/test/E2ETest/Tests/EventBubblingTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public void BubblingStandardEvent_FiredOnElementWithHandler()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23366")]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/31195")]
public void BubblingStandardEvent_FiredOnElementWithoutHandler()
{
Browser.Exists(By.Id("button-without-onclick")).Click();
Expand Down
6 changes: 3 additions & 3 deletions src/Components/test/E2ETest/Tests/EventTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ public void PreventDefault_AppliesToFormOnSubmitHandlers()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/25929")]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/31195")]
public void PreventDefault_DotNotApplyByDefault()
{
var appElement = Browser.MountTestComponent<EventPreventDefaultComponent>();
Expand All @@ -185,7 +185,7 @@ public void PreventDefault_DotNotApplyByDefault()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27397")]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/31195")]
public void InputEvent_RespondsOnKeystrokes()
{
Browser.MountTestComponent<InputEventComponent>();
Expand All @@ -203,7 +203,7 @@ public void InputEvent_RespondsOnKeystrokes()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23757")]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/31195")]
public void InputEvent_RespondsOnKeystrokes_EvenIfUpdatesAreLaggy()
{
// This test doesn't mean much on WebAssembly - it just shows that even if the CPU is locked
Expand Down
3 changes: 0 additions & 3 deletions src/Components/test/E2ETest/Tests/FormsTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ public void InputTextAreaInteractsWithEditContext()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27398")]
public void InputDateInteractsWithEditContext_NonNullableDateTime()
{
var appElement = MountTypicalValidationComponent();
Expand Down Expand Up @@ -304,7 +303,6 @@ public void InputCheckboxInteractsWithEditContext()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24850")]
public void InputRadioGroupWithoutNameInteractsWithEditContext()
{
var appElement = MountTypicalValidationComponent();
Expand Down Expand Up @@ -344,7 +342,6 @@ IWebElement FindBestAirlineInput()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24850")]
public void InputRadioGroupsWithNamesNestedInteractWithEditContext()
{
var appElement = MountTypicalValidationComponent();
Expand Down
1 change: 0 additions & 1 deletion src/Components/test/E2ETest/Tests/GlobalizationTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ public virtual void CanSetCultureAndParseCultureSensitiveNumbersAndDates(string
[Theory]
[InlineData("en-US")]
[InlineData("fr-FR")]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27155")]
public void CanSetCultureAndParseCultureInvariantNumbersAndDatesWithInputFields(string culture)
{
var cultureInfo = CultureInfo.GetCultureInfo(culture);
Expand Down
1 change: 0 additions & 1 deletion src/Components/test/E2ETest/Tests/PerformanceTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ public void HasTitle()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23366")]
public void BenchmarksRunWithoutError()
{
// In CI, we only verify that the benchmarks run without throwing any
Expand Down
4 changes: 2 additions & 2 deletions src/Components/test/E2ETest/Tests/RoutingTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -508,12 +508,12 @@ public void ResetsScrollPositionWhenPerformingInternalNavigation_ProgrammaticNav
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23596")]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/31195")]
public void PreventDefault_CanBlockNavigation_ForInternalNavigation_PreventDefaultTarget()
=> PreventDefault_CanBlockNavigation("internal", "target");

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23596")]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/31195")]
public void PreventDefault_CanBlockNavigation_ForExternalNavigation_PreventDefaultAncestor()
=> PreventDefault_CanBlockNavigation("external", "ancestor");

Expand Down
2 changes: 0 additions & 2 deletions src/Components/test/E2ETest/Tests/WebAssemblyLazyLoadTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ protected override void InitializeAsyncCore()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23856")]
public void CanLazyLoadOnRouteChange()
{
// Navigate to a page without any lazy-loaded dependencies
Expand All @@ -61,7 +60,6 @@ public void CanLazyLoadOnRouteChange()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23856")]
public void CanLazyLoadOnFirstVisit()
{
// Navigate to a page with lazy loaded assemblies for the first time
Expand Down

0 comments on commit 2c2df08

Please sign in to comment.