Add file_header_template to editorconfig #30132

Youssef1313 · 2021-02-12T06:00:12Z

This ensures all files have the proper header template in CI.
Also when adding new files from Solution Explorer, it will get pre-populated with the header template.

Youssef1313 · 2021-02-12T09:35:23Z

Before moving forward with applying a FixAll in more solution filters, can someone confirm you want this change?

Pilchie

This is super valuable, but likely to be a bit tricky. It might be easier to move directly to MIT, since parts of the repo are already licensed that way, and that's where we want to end up.

eng/tools/RepoTasks/DownloadFile.cs

Pilchie · 2021-02-12T18:29:50Z

src/Http/Routing/src/ArrayBuilder.cs

-// The .NET Foundation licenses this file to you under the MIT license.
-// See the LICENSE file in the project root for more information.
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.


This is incorrect, since it's copied source from something that was MIT.

@Pilchie Is there a list of solution filters that I shouldn't touch their license headers?

Pilchie · 2021-02-12T18:31:13Z

src/Caching/SqlServer/src/Columns.cs

-// Licensed to the .NET Foundation under one or more agreements.
-// The .NET Foundation licenses this file to you under the MIT license.
-// See the LICENSE file in the project root for more information.
+// Copyright (c) .NET Foundation. All rights reserved.


This code in Caching moved from dotnet/extensions which was MIT.

Pilchie · 2021-02-12T18:32:57Z

src/HttpClientFactory/Polly/src/DependencyInjection/PollyHttpClientBuilderExtensions.cs

-// Licensed to the .NET Foundation under one or more agreements.
-// The .NET Foundation licenses this file to you under the MIT license.
-// See the LICENSE file in the project root for more information.
+// Copyright (c) .NET Foundation. All rights reserved.


The HttpClientFactory stuff also came from extensions.

src/Shared/runtime/Http2/Hpack/DynamicTable.cs

Pilchie · 2021-02-12T18:36:33Z

Related to #18873.

Directory.Build.props

Youssef1313 · 2021-03-30T13:37:17Z

Using EnforceCodeStyleInBuild caused the following error because the analyzer assemblies come from the .NET SDK are for CodeAnalysis 3.10 packages. But, the compiler version is pinned to a version that doesn't support 3.10.

CSC(0,0): error CS8032: (NETCORE_ENGINEERING_TELEMETRY=Build) An instance of analyzer Microsoft.CodeAnalysis.UseExplicitTupleName.UseExplicitTupleNameDiagnosticAnalyzer cannot be created from /home/vsts/work/1/s/.dotnet/sdk/6.0.100-preview.3.21168.19/Sdks/Microsoft.NET.Sdk/codestyle/cs/Microsoft.CodeAnalysis.CodeStyle.dll : Could not load file or assembly 'Microsoft.CodeAnalysis, Version=3.10.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. The system cannot find the file specified..

Upgrading the compiler version introduced some nullable errors. I think I'll wait on this PR until you upgrade the compiler version and fix these errors. I'll convert to a draft until you move to the newer compiler version or I get to do this in a separate PR.

BrennanConroy · 2021-03-30T16:06:16Z

@dougbu Can you comment on #30132 (comment)?

dougbu · 2021-03-30T18:36:07Z

@dougbu Can you comment on #30132 (comment)?

Yes 😺

dougbu · 2021-03-30T18:41:03Z

The Build team doesn't treat the compiler version as infrastructure unless (and, yes, this has happened) a new version causes problems. We pinned the version to keep aspnetcore ahead of Arcade IIRC.

I have no general concerns about moving from 3.7.x to 3.10.x. Suggest working with @JamesNK and @pranavkm, both of whom have done a large amount of nullability-related changes. @Youssef1313 where were most of the new warnings or errors❔

Youssef1313 · 2021-03-30T18:44:07Z

@dougbu src/Http/Headers/src/BaseHeaderParser, src/Http/Headers/src/HttpHeaderParser, and src/Components/Components/src/RenderTree/RenderTreeEdit

BrennanConroy · 2021-03-31T16:39:29Z

I think I'll wait on this PR until you upgrade the compiler version and fix these errors

Done #31403

Youssef1313 · 2021-03-31T19:44:53Z

@Pilchie The size of the PR is growing crazy. Is that okay?

BrennanConroy · 2021-03-31T19:46:21Z

Is it possible to only apply this to part of the repo at a time?

Youssef1313 · 2021-03-31T19:49:42Z

Is it possible to only apply this to part of the repo at a time?

Yes, I can cherry-pick the commits here to multiple PRs. Would you be able to let me know which directories are owned by the same team to open as a separate PRs?

BrennanConroy · 2021-03-31T22:52:11Z

There are probably 5 main areas:
Mvc/
Components/
SignalR/
Servers/
Everything else/

Tratcher · 2021-04-01T17:09:39Z

Sorry @Youssef1313, we ran into a bureaucratic hurdle. We'll get it sorted out and get back to you here soon.

pranavkm · 2021-07-21T22:20:21Z

Closing this in lieu of #34573. Thanks for your time and effort though!

Youssef1313 requested a review from a team as a code owner February 12, 2021 07:50

Youssef1313 force-pushed the patch-2 branch from 0fe6d71 to d764385 Compare February 12, 2021 07:56

Youssef1313 marked this pull request as draft February 12, 2021 07:57

Youssef1313 marked this pull request as ready for review February 12, 2021 09:35

Youssef1313 requested review from halter73, javiercn, jkotalik, JunTaoLuo, Tratcher and a team as code owners February 12, 2021 09:35

Youssef1313 requested a review from a team February 12, 2021 09:35

Pilchie requested changes Feb 12, 2021

View reviewed changes

Pilchie reviewed Feb 12, 2021

View reviewed changes

src/Shared/runtime/Http2/Hpack/DynamicTable.cs Outdated Show resolved Hide resolved

Pilchie self-assigned this Feb 12, 2021

Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 12, 2021

BrennanConroy added the community-contribution Indicates that the PR has been added by a community member label Mar 29, 2021

Youssef1313 force-pushed the patch-2 branch from 590a2ca to 6b44114 Compare March 30, 2021 13:01

Youssef1313 commented Mar 30, 2021

View reviewed changes

Directory.Build.props Show resolved Hide resolved

Youssef1313 requested a review from dougbu as a code owner March 30, 2021 13:10

BrennanConroy mentioned this pull request Mar 30, 2021

Update Microsoft.Net.Compilers.Toolset #31403

Merged

Youssef1313 force-pushed the patch-2 branch from 36812c5 to 072a1e6 Compare March 31, 2021 16:43

Add file header template and enforce codestyle on build

abbcb2c

Youssef1313 added 18 commits March 31, 2021 20:47

Fix file header in src/DataProtection

f265b8e

Fix file header in src/Middleware

0effe4c

Fix file header in src/DefaultBuilder

f691542

Fix file header in src/Hosting

2981f9a

Fix file header in src/Servers

e5ce6ba

Fix file header in src/Middleware

c288c03

Fix file header in src/Security

273197a

Fix file header in src/Shared/Diagnostics

bd84c6c

Fix file header in src/Shared/EventSource.Testing

87d3307

Fix file header in src/Shared/HttpSys

96119cd

Fix file header in src/Shared/Process

61dc561

Fix file header in src/Shared/ValueStopwatch

c1d150a

Fix file header in src/Razor

aacd3b5

Fix file header in src/Shared/Razor

b77c595

Fix file header in src/Shared/RazorShared

5c6e6fc

Fix file header in src/Localization

563680c

Fix file header in src/JSInterop

044c0ce

Fix file header in src/Shared/JSInterop and src/Shared/LinkerFlags.cs

b228162

Youssef1313 marked this pull request as draft April 1, 2021 06:05

BrennanConroy mentioned this pull request Apr 1, 2021

Fix file header in src/Mvc #31430

Closed

Youssef1313 mentioned this pull request Apr 1, 2021

Fix file headers in src/SignalR #31433

Closed

Tratcher removed their request for review June 18, 2021 21:07

pranavkm closed this Jul 21, 2021

Youssef1313 deleted the patch-2 branch July 22, 2021 03:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add file_header_template to editorconfig #30132

Add file_header_template to editorconfig #30132

Youssef1313 commented Feb 12, 2021 •

edited

Loading

Youssef1313 commented Feb 12, 2021

Pilchie left a comment

Pilchie Feb 12, 2021

Youssef1313 Mar 30, 2021

Pilchie Feb 12, 2021

Pilchie Feb 12, 2021

Pilchie commented Feb 12, 2021

Youssef1313 commented Mar 30, 2021

BrennanConroy commented Mar 30, 2021

dougbu commented Mar 30, 2021

dougbu commented Mar 30, 2021

Youssef1313 commented Mar 30, 2021

BrennanConroy commented Mar 31, 2021

Youssef1313 commented Mar 31, 2021

BrennanConroy commented Mar 31, 2021

Youssef1313 commented Mar 31, 2021

BrennanConroy commented Mar 31, 2021

Tratcher commented Apr 1, 2021

pranavkm commented Jul 21, 2021

Add file_header_template to editorconfig #30132

Add file_header_template to editorconfig #30132

Conversation

Youssef1313 commented Feb 12, 2021 • edited Loading

Youssef1313 commented Feb 12, 2021

Pilchie left a comment

Choose a reason for hiding this comment

Pilchie Feb 12, 2021

Choose a reason for hiding this comment

Youssef1313 Mar 30, 2021

Choose a reason for hiding this comment

Pilchie Feb 12, 2021

Choose a reason for hiding this comment

Pilchie Feb 12, 2021

Choose a reason for hiding this comment

Pilchie commented Feb 12, 2021

Youssef1313 commented Mar 30, 2021

BrennanConroy commented Mar 30, 2021

dougbu commented Mar 30, 2021

dougbu commented Mar 30, 2021

Youssef1313 commented Mar 30, 2021

BrennanConroy commented Mar 31, 2021

Youssef1313 commented Mar 31, 2021

BrennanConroy commented Mar 31, 2021

Youssef1313 commented Mar 31, 2021

BrennanConroy commented Mar 31, 2021

Tratcher commented Apr 1, 2021

pranavkm commented Jul 21, 2021

Youssef1313 commented Feb 12, 2021 •

edited

Loading