Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/5.0] Resolve credscan bugs #32656

Merged
merged 3 commits into from
May 20, 2021
Merged

[release/5.0] Resolve credscan bugs #32656

merged 3 commits into from
May 20, 2021

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented May 13, 2021

Resolves remaining credscan bugs in this branch - anything in the suppressions file has already been approved via the same bugs in main

@wtgodbe wtgodbe requested review from Pilchie and a team May 13, 2021 20:50
Copy link
Member

@Pilchie Pilchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to deal with additional MusicStore issues in this branch?

@wtgodbe
Copy link
Member Author

wtgodbe commented May 13, 2021

Doug removed MusicStore: #31818

@Pilchie Pilchie added area-dataprotection Includes: DataProtection area-identity Includes: Identity and providers area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer labels May 14, 2021
@wtgodbe wtgodbe merged commit 028ea74 into release/5.0 May 20, 2021
@wtgodbe wtgodbe deleted the wtgodbe/Credscan50 branch May 20, 2021 17:35
@dougbu
Copy link
Member

dougbu commented May 20, 2021

The branches were open @wtgodbe

@wtgodbe
Copy link
Member Author

wtgodbe commented May 20, 2021

The branches were open @wtgodbe

Nope, we coordinated with tactics to merge them early since the deadline for credscan bugs is 5/28. I cancelled all of the internal builds.

@dougbu dougbu added the tell-mode Indicates a PR which is being merged during tell-mode label Jul 6, 2021
@dougbu dougbu added this to the 5.0.8 milestone Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer area-dataprotection Includes: DataProtection area-identity Includes: Identity and providers tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants