Playwright 🎭 🛠️ #45682

TanayParikh · 2022-12-19T22:27:08Z

Enable Playwright Tests

src/ProjectTemplates/README.md

src/ProjectTemplates/test/Templates.Blazor.Tests/BlazorWasmTemplateTest.cs

mkArtakMSFT · 2023-02-01T23:51:30Z

.azure/pipelines/ci.yml

@@ -697,7 +697,7 @@ stages:
          # Just uploading artifacts/logs/ files can take 15 minutes. Doubling the cancel timeout for this job.
          cancelTimeoutInMinutes: 30
          buildArgs: -all -pack -test -binaryLog /p:SkipHelixReadyTests=true /p:SkipIISNewHandlerTests=true /p:SkipIISTests=true
-                     /p:SkipIISExpressTests=true /p:SkipIISNewShimTests=true /p:RunTemplateTests=false
+                     /p:SkipIISExpressTests=true /p:SkipIISNewShimTests=true /p:RunTemplateTests=false /p:RunBlazorPlaywrightTemplateTests=true


Will setting this new variable (RunBlazorPlaywrightTemplateTests) to false result in the current behavior (as if we don't have this change in place)?

It's fine to just omit RunBlazorPlaywrightTemplateTests in that case as it'll default to using the value of RunTemplateTests, but yes setting it to false would work as well.

aspnetcore/src/ProjectTemplates/test/Templates.Blazor.Tests/Templates.Blazor.Tests.csproj

Lines 10 to 11 in 20ebf88

<RunBlazorPlaywrightTemplateTests Condition="'$(RunBlazorPlaywrightTemplateTests)' == ''">$(RunTemplateTests)</RunBlazorPlaywrightTemplateTests>

<SkipTests Condition="'$(RunBlazorPlaywrightTemplateTests)' != 'true'">true</SkipTests>

mkArtakMSFT · 2023-02-01T23:55:57Z

src/ProjectTemplates/test/Templates.Blazor.Tests/BlazorWasmTemplateTest.cs

@@ -107,7 +107,7 @@ private static async Task AssertCompressionFormat(AspNetProcess aspNetProcess, s
        Assert.Equal(expectedEncoding, response.Content.Headers.ContentEncoding.Single());
    }

-    [Theory(Skip = "https://github.com/dotnet/aspnetcore/issues/30882")]
+    [Theory(Skip = "https://github.com/dotnet/aspnetcore/issues/45736")]


The issue here was blocked on a Playwright issue, which they have resolved with the following comment:

Does that impact our decisions regarding this in any way?
I assume you're trying to wrap up your work already, and leaving this to be handled as part of the work on the linked issue is the right thing to do. So mostly wanted to note the progress on the dependency.

Going to try un-skipping this

Nope, still failing

ghost · 2023-02-10T15:00:48Z

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no breaking changes are introduced, please remove the pending ci rerun label to kick off a new CI run.

wtgodbe · 2023-02-13T18:54:43Z

The problem is that the Microsoft.AspNetCore.Components.WebAssembly package hasn't been built yet at the time the tests run (other packages like Microsoft.AspNetCore.Components.WebAssembly.Server are available). Trying to figure out if that always would have been the case or if something's changed here.

ghost · 2023-02-13T20:16:19Z

/azp run

azure-pipelines · 2023-02-13T20:16:24Z

Commenter does not have sufficient privileges for PR 45682 in repo dotnet/aspnetcore

wtgodbe

LGTM

TanayParikh added 13 commits December 19, 2022 14:17

Version Bumps

5f9b076

Run with Test: Windows Server x64

ceda987

Install Playwright in CI

68a2f8e

Add running playwright locally instructions

31cd474

Test Cleanup

5d86d72

Remove Selenium

02461a8

Prebuild for Playwright install

0de963b

Update default-build.yml

c803709

Update default-build.yml

e21e339

Update default-build.yml

c39f272

Update default-build.yml

a75e4b8

Update default-build.yml

89b5876

Playwright install in test

6ca74c2

build-analysis bot mentioned this pull request Dec 20, 2022

Request failed "500 Internal Server Error" dotnet/arcade#11737

Open

5 tasks

mkArtakMSFT reviewed Dec 20, 2022

View reviewed changes

src/ProjectTemplates/README.md Outdated Show resolved Hide resolved

TanayParikh added 15 commits December 20, 2022 15:43

New template test pipeline

ccbb4d4

Update components-e2e-tests.yml

599363d

Update components-template-tests.yml

3b5e7e3

Update components-e2e-tests.yml

7c6e078

Update components-e2e-tests.yml

c3a796a

Update components-e2e-tests.yml

90da3c8

Update components-template-tests.yml

80232fe

Update components-e2e-tests.yml

06577b1

Update components-e2e-tests.yml

2483583

Update components-e2e-tests.yml

52cf64c

Revert new pipeline changes

61ae061

RestoreAdditionalProjectSources

9ed27ed

Update Templates.Blazor.Tests.csproj

245485b

PR Feedback

4b43b23

RunBlazorPlaywrightTemplateTests

80250d0

TanayParikh added 3 commits January 23, 2023 08:28

Update Templates.Blazor.Tests.csproj

2e06f58

Merge branch 'main' into taparik/playwright

09e9cb2

Skip failing tests

20ebf88

TanayParikh marked this pull request as ready for review February 1, 2023 21:16

TanayParikh requested review from a team, dougbu and wtgodbe as code owners February 1, 2023 21:16

TanayParikh commented Feb 1, 2023

View reviewed changes

src/ProjectTemplates/test/Templates.Blazor.Tests/BlazorWasmTemplateTest.cs Outdated Show resolved Hide resolved

TanayParikh requested a review from a team February 1, 2023 21:18

MackinnonBuck approved these changes Feb 1, 2023

View reviewed changes

mkArtakMSFT reviewed Feb 1, 2023

View reviewed changes

mkArtakMSFT approved these changes Feb 1, 2023

View reviewed changes

Add #46430

c2d7a88

ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 10, 2023

Update Templates.Blazor.Tests.csproj

a33acf3

wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 13, 2023

wtgodbe approved these changes Feb 13, 2023

View reviewed changes

wtgodbe added 2 commits February 13, 2023 15:06

Update BlazorWasmTemplateTest.cs

f60b141

Update BlazorWasmTemplateTest.cs

704a4e1

wtgodbe merged commit c429024 into main Feb 14, 2023

wtgodbe deleted the taparik/playwright branch February 14, 2023 16:03

ghost added this to the 8.0-preview2 milestone Feb 14, 2023

hishamco mentioned this pull request Feb 14, 2023

UI testing with C# tests and Selenium with the Lombiq UI Testing Toolbox OrchardCMS/OrchardCore#12834

Open

wtgodbe mentioned this pull request Feb 14, 2023

Fix template tests to run in CI #46430

Closed

4 tasks

dougbu mentioned this pull request Feb 15, 2023

Update .npmrc approach and locked dependencies #46601

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Playwright 🎭 🛠️ #45682

Playwright 🎭 🛠️ #45682

TanayParikh commented Dec 19, 2022 •

edited

Loading

mkArtakMSFT Feb 1, 2023

TanayParikh Feb 3, 2023

mkArtakMSFT Feb 1, 2023

wtgodbe Feb 13, 2023

wtgodbe Feb 14, 2023

ghost commented Feb 10, 2023

wtgodbe commented Feb 13, 2023

ghost commented Feb 13, 2023

azure-pipelines bot commented Feb 13, 2023

wtgodbe left a comment

	<RunBlazorPlaywrightTemplateTests Condition="'$(RunBlazorPlaywrightTemplateTests)' == ''">$(RunTemplateTests)</RunBlazorPlaywrightTemplateTests>
	<SkipTests Condition="'$(RunBlazorPlaywrightTemplateTests)' != 'true'">true</SkipTests>

Playwright 🎭 🛠️ #45682

Playwright 🎭 🛠️ #45682

Conversation

TanayParikh commented Dec 19, 2022 • edited Loading

mkArtakMSFT Feb 1, 2023

Choose a reason for hiding this comment

TanayParikh Feb 3, 2023

Choose a reason for hiding this comment

mkArtakMSFT Feb 1, 2023

Choose a reason for hiding this comment

wtgodbe Feb 13, 2023

Choose a reason for hiding this comment

wtgodbe Feb 14, 2023

Choose a reason for hiding this comment

ghost commented Feb 10, 2023

wtgodbe commented Feb 13, 2023

ghost commented Feb 13, 2023

azure-pipelines bot commented Feb 13, 2023

wtgodbe left a comment

Choose a reason for hiding this comment

TanayParikh commented Dec 19, 2022 •

edited

Loading