Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Identity dependencies #53883

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

halter73
Copy link
Member

@halter73 halter73 commented Feb 8, 2024

The changes in #51430 never made it to the main branch, so this is taking the important bit so people running the .NET 9 preview templates don't see the issuer error fixed by AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#2361

@jennyf19 I decided to update to the latest versions available currently on NuGet, but this is a one-off PR. Should be automated? If so, how frequently?

@halter73 halter73 requested review from wtgodbe and a team as code owners February 8, 2024 01:14
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 8, 2024
@wtgodbe
Copy link
Member

wtgodbe commented Feb 12, 2024

We'll need to update source-build-externals in order to take this change without breaking source-build. @dotnet/dnceng @dotnet/source-build-internal is there a doc on how to do that?

@MichaelSimons
Copy link
Member

We'll need to update source-build-externals in order to take this change without breaking source-build. @dotnet/dnceng @dotnet/source-build-internal is there a doc on how to do that?

https://github.com/dotnet/source-build-externals?tab=readme-ov-file#updating-an-external-component-to-a-newer-version

The part that is not mentioned is that usually there would need to be coordination to get the source-build-externals PR and the consuming product repo to flow in together.

eng/Versions.props Outdated Show resolved Hide resolved
@halter73
Copy link
Member Author

I'll let the bot handle the IdentityModelVersion update since it seems to be taking care of that recently with dotnet/source-build-externals#252 and #53302. I only updated that since #51430 had and I figured why not.

We should only need to update the 2.13.4 versions to 2.15.2 or later to pick up the fix in AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#2361 which was my motivation for opening this PR.

@halter73 halter73 merged commit ba44ea8 into main Feb 14, 2024
26 checks passed
@halter73 halter73 deleted the halter73/main-identity-version-update branch February 14, 2024 20:42
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview2 milestone Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants