-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Blazor] Constructor injection #53915
Conversation
7e1f4a4
to
a404424
Compare
Can you document how we know this doesn't reintroduce the problems we had with constructor injection before? #40521 |
@SteveSandersonMS I suspect is dotnet/runtime@a48e73a It's essentially using new APIs. I haven't done size testing myself, but given we are early in the release, I think we can make this go in, and observe if we find any regression in our regular runs. Are you ok with that? |
a404424
to
ca2bbf1
Compare
It's less for us to keep track of if you just do a one-off manual publish locally to see the impact on final sizes, otherwise if some regression appears two weeks from now, we have to go through a whole detective process to trace it back to the cause. |
I did measure the change for the Blazor hosted app in release configuration between main and this branch and the size is the same. |
* Adds support for constructor injection in components.
Fixes #18088
Reverts 87f870d