Add os supported versions to host

[vitek-karas]

This change is Windows only.

• Add explicit manifest to dotnet.exe which specifies the supported OS versions.
• Remove any manifest from apphost.exe as it should get the manifest from the app when it's customized.

Fixes #3638

[vitek-karas]

@ericstj Any idea on how to test this? I thought about an app similar to your sample in the issue, but in order to validate it the test would somehow have to be able to determine the correct version of the OS it runs on - without any compatibility magic. Not sure if there's a way to do that.

[sbomer]

LGTM, thank you for fixing this!

[ericstj]

Make sure you test some set of apps with this change. Probably the built in apps plus the templates. We don’t want to break any of the basic scenarios and this does have that potential (due to turning off OS compatibility shims).

[vitek-karas]

by built-in apps you mean all the "dotnet something" tools?
I was thinking about adding some automated tests for this... but I can't figure out how to write the test verification (as it would see the same potentially wrong version of the OS or shims) - any ideas?

[ericstj]

Yeah, run dotnet tools. MSBuild is a good one, you could drop this version into a corefx repo and make sure it can still build, that'd be a nice test. For templates I was primarily thinking about dotnet new mvc, webapi, etc. Make sure none of those fall on the floor.

WRT to an automated test: you can call RtlGetVersion and it won't lie. This is what we do in System.Runtime.InteropServices.RuntimeInformation, but in that case we only expose it as a string:
https://github.com/dotnet/corefx/blob/1b16ca1c4bf1ea1a817bc4070362c53341e0ca10/src/Common/src/Interop/Windows/NtDll/Interop.RtlGetVersion.cs#L11-L34

So I imagine an automated test could fetch the current version from RtlGetVersion then ask VerifyVersionInfo to see if we're greater than or equal to that version. That'd have the nice characteristic of automatically failing when running on a new OS when we need to make a change.

[vitek-karas]

Added automated test for dotnet.exe OS support. Unfortunately adding the same for apphost.exe is just too expensive right now as we don't have the infra to test with freshly built apphost. For now I'll leave it out and I'm discussing options with the SDK team to overcome this limitation.

[vitek-karas]

I verified this with the new dotnet.exe:

• I can dotnet new and then dotnet run project types console,winforms,wpf,web,mvc,webapi - everything seems to work just fine
• I can build the CoreFx repo with the new dotnet.exe

I manually exported and double checked the manifest embeded in the new dotnet.exe - it contains the original manifest plus the supported OSes.

[ericstj]

test OSX x64 Release Build

[ericstj]

Do you need the #ifdef? It looks like you only ever run this on Windows.

[vitek-karas]

It is not needed, but I personally would prefer to keep it - makes it more explicit. I don't like code which doesn't run, but also doesn't work at all.

[vitek-karas]

test OSX x64 Release Build

[ericstj]

test OSX x64 Release Build