Add Async flag to SqlClient NamedPipes' PipeStream to resolve an issu…

…e with connection hangs while using MARS over NP. (#19022)
dotnet · Apr 27, 2017 · 9c668c8 · 9c668c8
1 parent 010b2e7
commit 9c668c8
Show file tree

Hide file tree

Showing 3 changed files with 40 additions and 3 deletions.
diff --git a/src/System.Data.SqlClient/src/System/Data/SqlClient/SNI/SNINpHandle.cs b/src/System.Data.SqlClient/src/System/Data/SqlClient/SNI/SNINpHandle.cs
@@ -46,7 +46,11 @@ public SNINpHandle(string serverName, string pipeName, long timerExpire, object
 
             try
             {
-                _pipeStream = new NamedPipeClientStream(serverName, pipeName, PipeDirection.InOut, PipeOptions.WriteThrough, Security.Principal.TokenImpersonationLevel.None);
+                _pipeStream = new NamedPipeClientStream(
+                    serverName,
+                    pipeName,
+                    PipeDirection.InOut,
+                    PipeOptions.Asynchronous | PipeOptions.WriteThrough);
 
                 bool isInfiniteTimeOut = long.MaxValue == timerExpire;
                 if (isInfiniteTimeOut)

diff --git a/src/System.Data.SqlClient/tests/ManualTests/SQL/LocalDBTest/LocalDBTest.cs b/src/System.Data.SqlClient/tests/ManualTests/SQL/LocalDBTest/LocalDBTest.cs
@@ -13,10 +13,25 @@ public static class LocalDBTest
         [ConditionalFact(nameof(IsLocalDBEnvironmentSet))]
         public static void LocalDBConnectionTest()
         {
-            SqlConnectionStringBuilder builder = new SqlConnectionStringBuilder("server=(localdb)\\MSSQLLocalDB");
+            SqlConnectionStringBuilder builder = new SqlConnectionStringBuilder(@"server=(localdb)\MSSQLLocalDB");
             builder.IntegratedSecurity = true;
             builder.ConnectTimeout = 2;
-            using (SqlConnection connection = new SqlConnection(builder.ConnectionString))
+            OpenConnection(builder.ConnectionString);
+        }
+
+        [ConditionalFact(nameof(IsLocalDBEnvironmentSet))]
+        public static void LocalDBMarsTest()
+        {
+            SqlConnectionStringBuilder builder = new SqlConnectionStringBuilder(@"server=(localdb)\MSSQLLocalDB;");
+            builder.IntegratedSecurity = true;
+            builder.MultipleActiveResultSets = true;
+            builder.ConnectTimeout = 2;
+            OpenConnection(builder.ConnectionString);
+        }
+
+        private static void OpenConnection(string connString)
+        {
+            using (SqlConnection connection = new SqlConnection(connString))
             {
                 connection.Open();
                 using (SqlCommand command = new SqlCommand("SELECT @@SERVERNAME", connection))

diff --git a/src/System.Data.SqlClient/tests/ManualTests/SQL/MARSTest/MARSTest.cs b/src/System.Data.SqlClient/tests/ManualTests/SQL/MARSTest/MARSTest.cs
@@ -13,6 +13,24 @@ public static class MARSTest
     {
         private static readonly string _connStr = (new SqlConnectionStringBuilder(DataTestUtility.TcpConnStr) { MultipleActiveResultSets = true }).ConnectionString;
 
+        [CheckConnStrSetupFact]
+        public static void NamedPipesMARSTest()
+        {
+            SqlConnectionStringBuilder builder = new SqlConnectionStringBuilder(DataTestUtility.NpConnStr);
+            builder.MultipleActiveResultSets = true;
+            builder.ConnectTimeout = 5;
+
+            using (SqlConnection conn = new SqlConnection(builder.ConnectionString))
+            {
+                conn.Open();
+                using (SqlCommand command = new SqlCommand("SELECT @@SERVERNAME", conn))
+                {
+                    var result = command.ExecuteScalar();
+                    Assert.NotNull(result);
+                }
+            }
+        }
+
 #if DEBUG
         [CheckConnStrSetupFact]
         public static void MARSAsyncTimeoutTest()