Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print warning message when project file does not contain any documents. #1734

Merged
merged 1 commit into from
Jun 8, 2017

Conversation

dlech
Copy link
Contributor

@dlech dlech commented Jun 6, 2017

Currently, roslyn does not seem to pick up source files from the "new" csproj format where .cs source files are implicitly included (I even updated to the latest pre-release roslyn nuget packages). So, to help diagnose this lack of support, print a warning message.

@dnfclas
Copy link

dnfclas commented Jun 6, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@dlech
Copy link
Contributor Author

dlech commented Jun 6, 2017

This could have helped me in troubleshooting #1708 (comment)

Also, this handles one possible case for #1686

@hellosnow
Copy link
Contributor

:shipit:

Currently, roslyn does not seem to pick up source files from the "new" csproj format where .cs source files are implicitly included (I even updated to the latest pre-release roslyn nuget packages). So, to help diagnose this lack of support, print a warning message.
@dlech dlech force-pushed the no-project-docs-warning branch from 92428af to 6e71665 Compare June 7, 2017 16:21
@vicancy vicancy merged commit 58395d0 into dotnet:dev Jun 8, 2017
@dlech dlech deleted the no-project-docs-warning branch October 11, 2019 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants