Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document IncludeAllContentForSelfExtract #21828

Merged
merged 3 commits into from
Jan 15, 2021
Merged

Document IncludeAllContentForSelfExtract #21828

merged 3 commits into from
Jan 15, 2021

Conversation

NN---
Copy link
Contributor

@NN--- NN--- commented Dec 4, 2020

No description provided.

@adegeo
Copy link
Contributor

adegeo commented Dec 4, 2020

@NN--- thank you for the submission! We'll get it reviewed and added.

@LakshanF Can you shed some light on IncludeAllContentForSelfExtract? How does it affect the running of the app? I want to make sure this is accurate and also perhaps clarify some other parts of the article.

@adegeo adegeo added the ✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository label Dec 4, 2020
@LakshanF
Copy link
Member

LakshanF commented Dec 4, 2020

cc @agocke as well

@NN---
Copy link
Contributor Author

NN--- commented Dec 4, 2020

Sure.

This flag makes single-file application working as it did in .NET Core 3.
It first extracts the files to the disk and then loads assemblies from the files in the disk.
By default without this flag, .NET 5.0 doesn't extract anything and uses everything in process memory.

This flag appears in few issues and some articles in the internet but doesn't appear in documentation.
It is essential for licenses which require dynamic loading if you want your application to use other license.

@agocke
Copy link
Member

agocke commented Dec 4, 2020

LGTM -- we should also probably document IncludeNativeLibrariesForSelfExtract

@NN---
Copy link
Contributor Author

NN--- commented Dec 4, 2020

@agocke
Copy link
Member

agocke commented Dec 4, 2020

Ah, in the "other considerations." In that case, let's not create a new section here and put those together. I certainly wouldn't want to encourage use of IncludeAllContent vs IncludeNativeLibraries

@NN---
Copy link
Contributor Author

NN--- commented Dec 5, 2020

Updated

@NN--- NN--- requested a review from agocke December 5, 2020 12:41
Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adegeo
Copy link
Contributor

adegeo commented Dec 9, 2020

@NN--- Just noting that your original suggestion was deleted and replaced by a different one?

@NN---
Copy link
Contributor Author

NN--- commented Dec 18, 2020

Yes. I updated according to the review comment.

@agocke
Copy link
Member

agocke commented Jan 14, 2021

@adegeo Can we merge this?

@adegeo adegeo merged commit ea2d897 into dotnet:master Jan 15, 2021
@NN--- NN--- deleted the patch-1 branch September 4, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants