-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document IncludeAllContentForSelfExtract #21828
Conversation
cc @agocke as well |
Sure. This flag makes single-file application working as it did in .NET Core 3. This flag appears in few issues and some articles in the internet but doesn't appear in documentation. |
LGTM -- we should also probably document |
It is documented https://docs.microsoft.com/en-us/dotnet/core/deploying/single-file |
Ah, in the "other considerations." In that case, let's not create a new section here and put those together. I certainly wouldn't want to encourage use of |
Updated |
Co-authored-by: Andy Gocke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@NN--- Just noting that your original suggestion was deleted and replaced by a different one? |
Yes. I updated according to the review comment. |
@adegeo Can we merge this? |
No description provided.