Use .NET 8.0 UnreachableException where appropriate (#31299)

src/EFCore.Cosmos/Query/Internal/CosmosShapedQueryCompilingExpressionVisitor.InExpressionValuesExpandingExpressionVisitor.cs

@@ -72,7 +72,7 @@ public override Expression Visit(Expression expression)
                     }
 
                     default:
-                        throw new InvalidOperationException("IMPOSSIBLE");
+                        throw new UnreachableException();
                 }
 
                 var updatedInExpression = inValues.Count > 0

src/EFCore.Relational/Query/Internal/SqlExpressionSimplifyingExpressionVisitor.cs

@@ -282,7 +282,7 @@ or ExpressionType.LessThan
                     {
                         ExpressionType.Equal => inExpression,
                         ExpressionType.NotEqual => _sqlExpressionFactory.Not(inExpression),
-                        _ => throw new InvalidOperationException("IMPOSSIBLE")
+                        _ => throw new UnreachableException()
                     };
                 }
             }

src/EFCore.Relational/Query/RelationalQueryableMethodTranslatingExpressionVisitor.cs

@@ -2700,7 +2700,7 @@ SelectExpression subquery
                         => subquery.Projection.FirstOrDefault(p => p.Alias == columnExpression.Name) is { Expression.TypeMapping: null },
 
                     JoinExpressionBase
-                        => throw new InvalidOperationException("Impossible: nested join"),
+                        => throw new UnreachableException("Impossible: nested join"),
 
                     // Any other table expression is considered a root (TableValuedFunctionExpression, ValuesExpression...) which *may* be
                     // untyped, so we record the possible inference (note that TableValuedFunctionExpression may be typed, or not)

src/EFCore.Relational/Query/RelationalShapedQueryCompilingExpressionVisitor.ShaperProcessingExpressionVisitor.cs

@@ -1453,7 +1453,7 @@ protected override Expression VisitSwitch(SwitchExpression switchExpression)
                                 newInstanceVariable);
                             break;
                         default:
-                            throw new InvalidOperationException("IMPOSSIBLE");
+                            throw new UnreachableException();
                     }
 
                     var managerVariable = Variable(typeof(Utf8JsonReaderManager), "jsonReaderManager");

src/EFCore.Relational/Query/SqlExpressions/SelectExpression.cs

@@ -3256,7 +3256,7 @@ or ExpressionType.LessThan
                             ExpressionType.GreaterThan => ExpressionType.LessThan,
                             ExpressionType.GreaterThanOrEqual => ExpressionType.LessThanOrEqual,
 
-                            _ => throw new InvalidOperationException("IMPOSSIBLE")
+                            _ => throw new UnreachableException()
                         };
 
                         return new SqlBinaryExpression(

src/EFCore.Sqlite.Core/Update/Internal/SqliteModificationCommand.cs

@@ -61,7 +61,7 @@ protected override void ProcessSinglePropertyJsonUpdate(ref ColumnModificationPa
                 {
                     true => "true",
                     false => "false",
-                    _ => throw new Exception("IMPOSSIBLE")
+                    _ => throw new UnreachableException()
                 }
             };
 

src/Shared/Check.cs

@@ -112,12 +112,12 @@ public static void DebugAssert([DoesNotReturnIf(false)] bool condition, string m
     {
         if (!condition)
         {
-            throw new Exception($"Check.DebugAssert failed: {message}");
+            throw new UnreachableException($"Check.DebugAssert failed: {message}");
         }
     }
 
     [Conditional("DEBUG")]
     [DoesNotReturn]
     public static void DebugFail(string message)
-        => throw new Exception($"Check.DebugFail failed: {message}");
+        => throw new UnreachableException($"Check.DebugFail failed: {message}");
 }