Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrations and model snapshot for primitive collections #31414

Closed
ajcvickers opened this issue Aug 6, 2023 · 3 comments · Fixed by #31666
Closed

Migrations and model snapshot for primitive collections #31414

ajcvickers opened this issue Aug 6, 2023 · 3 comments · Fixed by #31666
Assignees
@bricelam
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
8.0.0

Comments

@ajcvickers
Copy link
Member

No description provided.

@ajcvickers ajcvickers self-assigned this Aug 6, 2023
@bricelam bricelam self-assigned this Sep 5, 2023
@bricelam
Copy link
Contributor

bricelam commented Sep 5, 2023

Double-check complex type coverage too

@ajcvickers ajcvickers added this to the 8.0.0 milestone Sep 6, 2023
@bricelam
Copy link
Contributor

bricelam commented Sep 7, 2023

From #31630 (comment)

check that we're not putting user CLR types in migrations for primitive collections (or complex types)

@bricelam
Copy link
Contributor

bricelam commented Sep 7, 2023

Not seeing any issues with primitive collections. They really are just strings to migrations and the snapshot. I'll double-check that we have automated tests before closing.

Seeing a few issues with complex types. I'll keep testing and file separate issues.

bricelam added a commit to bricelam/efcore that referenced this issue Sep 8, 2023
@bricelam
Migrations: Fix ComplexPropertyBuilder.IsRequired call in snapshot
284e941 
Fixes dotnet#31665, resolves dotnet#31414
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Sep 8, 2023
@bricelam bricelam modified the milestones: 8.0.0, 8.0.0-rc2 Sep 8, 2023
@bricelam bricelam mentioned this issue Sep 8, 2023
Merged
bricelam added a commit that referenced this issue Sep 8, 2023
@bricelam
Migrations: Fix ComplexPropertyBuilder.IsRequired call in snapshot (#…
63b1e0a 
…31666)

Fixes #31665, resolves #31414
@ajcvickers ajcvickers modified the milestones: 8.0.0-rc2, 8.0.0 Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Migrations: Fix ComplexPropertyBuilder.IsRequired call in snapshot bricelam/efcore
2 participants
@bricelam @ajcvickers