-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ChatClientBuilder to register singletons and support lambda-less chaining #5642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that I'll do the equivalent thing for |
stephentoub
reviewed
Nov 14, 2024
...aries/Microsoft.Extensions.AI/ChatCompletion/ChatClientBuilderServiceCollectionExtensions.cs
Show resolved
Hide resolved
stephentoub
reviewed
Nov 14, 2024
src/Libraries/Microsoft.Extensions.AI/ChatCompletion/ChatClientBuilder.cs
Show resolved
Hide resolved
stephentoub
reviewed
Nov 14, 2024
...aries/Microsoft.Extensions.AI/ChatCompletion/ChatClientBuilderServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the new approach looks much more intuitive.
stephentoub
pushed a commit
to stephentoub/extensions
that referenced
this pull request
Nov 19, 2024
…ss chaining (dotnet#5642) * Change ChatClientBuilder to register singletons and support lambda-less chaining * Add generic keyed version * Improve XML doc * Update README files * Remove generic DI registration methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5572 as well as changing the default DI lifetime from scoped to singleton.
This is also needed for the API design we want in dotnet/aspire#6225
Usage with DI (common)
Before:
After:
Usage without DI (uncommon)
Before:
After:
Summary
In the non-DI case it doesn't make much difference. It's a small improvement though, since it avoids the
Use
method having totally different semantics based on which oveload is called.But in the DI case which is more common, it's simpler and more approachable as there's no need for the lambda.
It also has value for the Aspire helpers as it make it possible to do this API, which we can't otherwise achieve since you can't specify the inner client up front and can only do so once the rest of the pipeline is built.
Microsoft Reviewers: Open in CodeFlow