Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support file globbing in --include and --exclude options #555

Merged
merged 9 commits into from
Feb 17, 2020
Merged

Support file globbing in --include and --exclude options #555

merged 9 commits into from
Feb 17, 2020

Conversation

JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Feb 16, 2020 •
edited
Loading

Use the Microsoft.Extensions.FileSystemGlobbing package to handle matching against the included and excluded paths.

@JoeRobich
Copy link
Member Author

@jmarolf PTAL

@JoeRobich JoeRobich force-pushed the support-file-globbing branch 3 times, most recently from c676562 to 571e027 Compare February 16, 2020 22:25
@JoeRobich JoeRobich force-pushed the support-file-globbing branch from 571e027 to 3c32a0a Compare February 16, 2020 22:26
jmarolf
jmarolf approved these changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@jmarolf jmarolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jmarolf
Copy link
Contributor

jmarolf commented Feb 17, 2020

As long as Perf.cmd works on your machine I have no concerns

@JoeRobich
Copy link
Member Author

Seemed to run fine. Thanks!

@JoeRobich JoeRobich merged commit 3556f2c into dotnet:master Feb 17, 2020
@JoeRobich JoeRobich deleted the support-file-globbing branch February 17, 2020 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmarolf jmarolf jmarolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeRobich @jmarolf