Move to Roslyn's editorconfig support #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jmarolf please take a look |
sharwell
reviewed
Mar 17, 2020
JoeRobich
force-pushed
the
roslyn-editorconfig
branch
from
da26abd
to
aeda79e
Compare
Closed
JoeRobich
force-pushed
the
roslyn-editorconfig
branch
from
d8a66bb
to
9f87221
Compare
JoeRobich
force-pushed
the
roslyn-editorconfig
branch
from
9f87221
to
1c03fa2
Compare
jmarolf
approved these changes
May 26, 2020
| var analyzerConfigOptions = await GetAnalyzerConfigOptionsAsync(document, cancellationToken).ConfigureAwait(false); | ||
| var optionSet = await document.GetOptionsAsync(cancellationToken).ConfigureAwait(false); | ||
|
|
||
| var formattableDocument = new DocumentWithOptions(document, optionSet, analyzerConfigOptions); |
There was a problem hiding this comment.
Why is DocumentWithOptions needed if we can fetch the OptionSet when you need it later or potentially the AnalyzerConfigOptions too? Is this just a perf optimization or needed for something else?
There was a problem hiding this comment.
I thought I was saving work, but you are right. Since nothing in the solution is changing and these are cached within the DocumentState and AnalyzerConfigSet respectively. This could just return document ids and we could fetch everything again later.
There was a problem hiding this comment.
I'll take this suggestion as a follow up refactoring. #691
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.