Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FS-1081] - Extended fixed bindings #15697

Merged
merged 62 commits into from
Aug 15, 2023
Merged

[FS-1081] - Extended fixed bindings #15697

merged 62 commits into from
Aug 15, 2023

Conversation

jwosty
Copy link
Contributor

@jwosty jwosty commented Jul 27, 2023 •
edited
Loading

Implementation for RFC FS-1081: https://github.com/fsharp/fslang-design/blob/main/FSharp-8.0/FS-1081-extended-fixed-bindings.md

Tasks:

@jwosty
Copy link
Contributor Author

jwosty commented Jul 27, 2023

Should we also address #9251 in this PR? The compiler could check if the referenced string type has GetPinnableReference and if so, take the new path.

@vzarytovskii
Copy link
Member

Should we also address #9251 in this PR? The compiler could check if the referenced string type has GetPinnableReference and if so, take the new path.

Yeah, this should be fine, just make sure both features are under preview language version (under same or separate flags).

@jwosty jwosty changed the title [FS-1081] - Extended fixed expressions [FS-1081] - Extend fixed expressions Jul 27, 2023
@jwosty jwosty force-pushed the jw-fs1081-extend-fixed-expressions branch from 36922da to 53b5920 Compare July 28, 2023 01:13
@jwosty jwosty changed the title [FS-1081] - Extend fixed expressions [FS-1081] - Extended fixed expressions Jul 28, 2023
@jwosty jwosty changed the title [FS-1081] - Extended fixed expressions [FS-1081] - Extended fixed bindings Jul 28, 2023
vzarytovskii
vzarytovskii approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@vzarytovskii vzarytovskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, that looks good to me, thanks!

@vzarytovskii vzarytovskii enabled auto-merge (squash) August 14, 2023 20:49
auto-merge was automatically disabled August 14, 2023 21:25

Head branch was pushed to by a user without write access

@vzarytovskii vzarytovskii merged commit 0bfd490 into dotnet:main Aug 15, 2023
24 checks passed
@jwosty jwosty deleted the jw-fs1081-extend-fixed-expressions branch August 15, 2023 14:07
@allisonchou allisonchou mentioned this pull request Aug 16, 2023
Closed
@jwosty jwosty mentioned this pull request Aug 16, 2023
Open
5 tasks
@jwosty jwosty mentioned this pull request Aug 26, 2023
Closed
@jwosty jwosty mentioned this pull request Nov 9, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki left review comments

@edgarfgp edgarfgp edgarfgp approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees
No one assigned
Labels
release/17.8
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jwosty @vzarytovskii @psfinaki @edgarfgp