Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0.1xx] Update dependencies from dotnet/sdk #17597

Merged
merged 29 commits into from
Oct 25, 2023
Merged

[release/8.0.1xx] Update dependencies from dotnet/sdk #17597

merged 29 commits into from
Oct 25, 2023

Conversation

dotnet-maestro[bot]
Copy link

@dotnet-maestro dotnet-maestro bot commented Oct 23, 2023 •
edited
Loading

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.WindowsDesktop.App.Ref: from 8.0.0-rtm.23519.16 to 8.0.0-rtm.23521.1 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0: from 8.0.0-rtm.23519.16 to 8.0.0-rtm.23521.1 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0: from 8.0.0-rtm.23519.16 to 8.0.0-rtm.23521.1 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.NetCore.SharedFramework.x64.8.0: from 8.0.0-rtm.23519.13 to 8.0.0-rtm.23520.16 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.App.Ref: from 8.0.0-rtm.23519.13 to 8.0.0-rtm.23520.16 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.NetCore.TargetingPack.x64.8.0: from 8.0.0-rtm.23519.13 to 8.0.0-rtm.23520.16 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.App.Host.win-x64: from 8.0.0-rtm.23519.13 to 8.0.0-rtm.23520.16 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.DotNetHostResolver: from 8.0.0-rtm.23519.13 to 8.0.0-rtm.23520.16 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.Platforms: from 8.0.0-rtm.23519.13 to 8.0.0-rtm.23520.16 (parent: Microsoft.NET.Sdk)
    • Microsoft.WindowsDesktop.App.Runtime.win-x64: from 8.0.0-rtm.23519.16 to 8.0.0-rtm.23521.1 (parent: Microsoft.NET.Sdk)
    • Microsoft.Dotnet.WinForms.ProjectTemplates: from 8.0.0-rtm.23519.9 to 8.0.0-rtm.23520.14 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
    • Microsoft.WindowsDesktop.App.Runtime.win-x64: from 8.0.0-rtm.23519.16 to 8.0.0-rtm.23521.1 (parent: Microsoft.NET.Sdk)
    • Microsoft.DotNet.Wpf.ProjectTemplates: from 8.0.0-rtm.23519.13 to 8.0.0-rtm.23521.1 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
    • Microsoft.NET.ILLink.Tasks: from 8.0.0-rtm.23519.13 to 8.0.0-rtm.23520.16 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.App.Runtime.win-x64: from 8.0.0-rtm.23519.13 to 8.0.0-rtm.23520.16 (parent: Microsoft.NET.Sdk)

From https://github.com/dotnet/sdk

  • Subscription: f7b93743-a9dd-40f3-c2e9-08db9f4b159c
  • Build: 20231024.25
  • Date Produced: October 24, 2023 10:14:54 PM UTC
  • Commit: a08f8900d1b7f4cef2a1077dc4ce90c56cb4ada5
  • Branch: refs/heads/release/8.0.1xx

@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231022.6
7632159 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-rtm.23520.55 -> To Version 8.0.100-rtm.23522.6

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-rtm.23519.16 -> To Version 8.0.0-rtm.23521.1 (parent: Microsoft.NET.Sdk
@v-wuzhai v-wuzhai requested a review from a team October 23, 2023 06:00
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231022.10
aecafd6 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-rtm.23520.55 -> To Version 8.0.100-rtm.23522.10

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-rtm.23519.16 -> To Version 8.0.0-rtm.23521.1 (parent: Microsoft.NET.Sdk
@MichaelSimons MichaelSimons mentioned this pull request Oct 23, 2023
Merged
@MichaelSimons
Copy link
Member

@ViktorHofer it looks like this is the same issue encountered in main - #17187. dotnet/runtime#93862 will need to be ported to release/8.0.

@mthalman mthalman mentioned this pull request Oct 23, 2023
Closed
@ViktorHofer
Copy link
Member

This should now be resolved with dotnet/runtime#93865

dotnet-maestro bot added 10 commits October 23, 2023 16:08
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231023.5
6ac8f55 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-rtm.23520.55 -> To Version 8.0.100-rtm.23523.5

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Runtime.win-x64
 From Version 8.0.0-rtm.23519.16 -> To Version 8.0.0-rtm.23521.1 (parent: Microsoft.NET.Sdk
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231023.8
3d8c42f 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-rtm.23520.55 -> To Version 8.0.100-rtm.23523.8
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231023.10
fa1048d 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-rtm.23520.55 -> To Version 8.0.100-rtm.23523.10
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231023.19
521e8a9 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-rtm.23520.55 -> To Version 8.0.100-rtm.23523.19
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231023.29
744ab40 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-rtm.23520.55 -> To Version 8.0.100-rtm.23523.29
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231023.42
b41773c 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-rtm.23520.55 -> To Version 8.0.100-rtm.23523.42
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231024.1
c8538a9 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-rtm.23520.55 -> To Version 8.0.100-rtm.23524.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231024.4
2bba254 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-rtm.23520.55 -> To Version 8.0.100-rtm.23524.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231024.7
197955f 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-rtm.23520.55 -> To Version 8.0.100-rtm.23524.7
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231024.11
a8a9322 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-rtm.23520.55 -> To Version 8.0.100-rtm.23524.11
@ViktorHofer
Copy link
Member

@mmitche this PR now needs the stabilized package version feed added to NuGet.config, right?

@mmitche
Copy link
Member

mmitche commented Oct 24, 2023

Yep. Note that no dependencies in the update were stabilized.

@mmitche
Copy link
Member

mmitche commented Oct 24, 2023

I think this is a coherency issue. Something downstack (templating? sdk?) is referencing S.T.J at a stable version, but the stable runtime hasn't flowed into sdk, and thus hasn't flowed into installer.

@mmitche
Copy link
Member

mmitche commented Oct 24, 2023

@lewing I think you may have changed some dependencies in runtime yesterday?

Coherency update failed for the following dependencies:

https://github.com/dotnet/runtime @ 488a8a3521610422e8fbe22d5cc66127f3dce3dc does not contain dependency Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
PotentialSolutions:
Add the dependency to https://github.com/dotnet/runtime.
Pin the dependency.
Remove the CoherentParentDependency attribute.
The documentation can be found at this location: https://github.com/dotnet/arcade/blob/main/Documentation/Darc.md#coherent-parent-dependencies

@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231024.13
fb73b47 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-rtm.23520.55 -> To Version 8.0.100
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231024.16
bb33c0f 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-rtm.23520.55 -> To Version 8.0.100
@mmitche
Copy link
Member

mmitche commented Oct 24, 2023

I think this Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport may just need to be updated to Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100

@mmitche mmitche enabled auto-merge (squash) October 24, 2023 19:44
dotnet-maestro bot and others added 3 commits October 24, 2023 20:01
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231024.15
61ca5bb 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-rtm.23520.55 -> To Version 8.0.100
@mmitche
Fix coherency
f995106
@mmitche
Merge branch 'darc-release/8.0.1xx-ce76b902-9300-4ba4-a046-93a4517926…
79e3e4f 
…2f' of https://github.com/dotnet/installer into darc-release/8.0.1xx-ce76b902-9300-4ba4-a046-93a45179262f
mmitche and others added 11 commits October 24, 2023 13:06
@mmitche
Merge branch 'release/8.0.1xx' into darc-release/8.0.1xx-ce76b902-930…
6df78e0 
…0-4ba4-a046-93a45179262f
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231024.19
4c0a235 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-rtm.23520.55 -> To Version 8.0.100
@mmitche
Update dependency name
f660712
@mmitche
Merge branch 'darc-release/8.0.1xx-ce76b902-9300-4ba4-a046-93a4517926…
3030a88 
…2f' of https://github.com/dotnet/installer into darc-release/8.0.1xx-ce76b902-9300-4ba4-a046-93a45179262f
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231024.23
d8ce322 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-rtm.23520.55 -> To Version 8.0.100
@mmitche
Fixup emsdk SB dep
f09ee0b
@mmitche
Merge branch 'darc-release/8.0.1xx-ce76b902-9300-4ba4-a046-93a4517926…
ecb7ca2 
…2f' of https://github.com/dotnet/installer into darc-release/8.0.1xx-ce76b902-9300-4ba4-a046-93a45179262f
@dotnet-maestro
Update dependencies from https://github.com/dotnet/sdk build 20231024.25
fa70a8f 
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-rtm.23520.55 -> To Version 8.0.100
@mmitche
Re-add SDK feed
994656c
@mmitche
Coherency
da577be
@mmitche
Merge branch 'release/8.0.1xx' into darc-release/8.0.1xx-ce76b902-930…
ce2d2a0 
…0-4ba4-a046-93a45179262f
@mmitche
Copy link
Member

mmitche commented Oct 25, 2023

Some of the smoke tests here failed, I think due to missing stable feeds in the test configuration. I'm going to merge this now to get coherency back into good shape, and re-enable the subscription so that this can be investigated in the next PR.

@mmitche mmitche disabled auto-merge October 25, 2023 00:26
@mmitche
Copy link
Member

mmitche commented Oct 25, 2023

Some of the smoke tests here failed, I think due to missing stable feeds in the test configuration. I'm going to merge this now to get coherency back into good shape, and re-enable the subscription so that this can be investigated in the next PR.

@dotnet/source-build-internal

@mmitche mmitche merged commit 1dd37f8 into release/8.0.1xx Oct 25, 2023
16 of 22 checks passed
@mmitche mmitche deleted the darc-release/8.0.1xx-ce76b902-9300-4ba4-a046-93a45179262f branch October 25, 2023 00:26
@mthalman mthalman mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitche mmitche mmitche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelSimons @ViktorHofer @mmitche