-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolate package flow between repos #18557
Merged
Merged
Changes from 25 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
0ea4e6c
Isolate package flow between repos
mthalman 3878626
Compute transitive dependencies
mthalman 823a8aa
Swap dep graph visualizer with a simple YAML-based representation
mthalman edebea7
Fix dependency on scenario-tests
mthalman 5b8a5a2
Remove duplicate installer dependency
mthalman 566f613
Delete obsolete installer-deps
mthalman 8ce569e
Add conditional deps specific to source build
mthalman 4611a5e
Merge branch 'main' into sb3608-parallel
mthalman fe61fb5
Merge branch 'main' into sb3608-parallel
mthalman d18498a
Updates to integrate with artifact path refactoring
mthalman 6f33ebb
Merge branch 'main' into sb3608-parallel
mthalman 608e3ad
Add back primary dependencies
mthalman a7a6f79
Move psb references
mthalman bdaa440
Use Exclude instead of Condition
mthalman 241ad6f
whitespace
mthalman a50512d
Remove MakeDir for package dirs
mthalman c97b8d2
Add comment for embedding
mthalman 8b3f3b2
indenting
mthalman 8834743
Remove TransitiveRepositoryReference instead of RepositoryReference, …
mthalman 0540025
Remove SkipEnsurePackagesCreated
mthalman 3c0edf6
Remove SharedOutputPath MakeDir
mthalman fe82c36
Use Copy instead of ln
mthalman 816e8dc
Separate SB refs into separate ItemGroup
mthalman 4d7ac80
dependency adjustments
mthalman 2be9e44
Renames to remove "SourceBuild"
mthalman a0117ac
Reclassify fsharp dep on runtime
mthalman afb34ea
Reclassify msbuild dep on runtime
mthalman bb5af84
Add runtime dep to templating
mthalman fe469d7
Remove whitespace
mthalman 308159f
Remove psb dep on scenario-tests
mthalman 19bc3f3
Remove whitespace
mthalman 5f14aa3
Reclassify format dep on symreader
mthalman 80ba493
Use directory normalization
mthalman 7d574e2
Simplify package file collection
mthalman a0599e1
Add whitespace
mthalman 6e800d7
Simplify _BuildSources
mthalman 59013c6
Get repo refs in parallel
mthalman 28f645a
Use Distinct
mthalman 0dfac72
whitespace
mthalman d1b1de0
Merge branch 'main' into sb3608-parallel
mthalman 2c3836b
Move windowsdesktop dep from sdk to installer
mthalman 9a25ae6
Revert "Use Distinct"
mthalman 5420993
Remove unnecessary normalize calls
mthalman 2303610
Update src/SourceBuild/content/repo-projects/package-source-build.proj
mthalman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
49 changes: 0 additions & 49 deletions
49
src/SourceBuild/content/eng/tools/generate-graphviz/generate-graphviz.proj
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
169 changes: 130 additions & 39 deletions
169
src/SourceBuild/content/repo-projects/Directory.Build.targets
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love that we have a pretty consistent pattern of comparing
'$(RepositoryName)' != 'source-build-reference-packages'
in various places throughoutDirectory.Build.targets
andDirectory.Build.props
.@jkoritzinsky added a new concept of a reference only repo here that would be good to use after his PR goes in. https://github.com/dotnet/installer/pull/18672/files#diff-0802dca0f4d533e4f44a76e021486aefa13bc1b193f018433b0d056ae84c9f3cR407-R408