-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support testing with JDK 17 #1108
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/android#8029 Update `<JdkInfo/>` task to emit a new `$(Java*MajorVersion)` MSBuild property. This is used by `src/Java.Base` so that it knows which JDK version it's binding. Begin explicitly qualifying all `$(Jdk*)` and `$(Java*)` MSBuild properties to explicitly disambiguate between JDK 1.8 and JDK-11 contexts. Eventually we may "swap" things so that properties without a version are for e.g. JDK 11 (17, etc.) and `$(Jdk8*)` is for JDK 1.8-requiring contexts. Note: to get this to *build* we had to update `src/Java.Base` to support binding against JDK-17, which was an expected diversion. This "JDK-17 Java.Base binding" was a "time limited" effort.
Unit tests "manually" read the `JdkInfo*.props` files, and since the file names and property names changed, things broke. Oops.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
May 11, 2023
Java.Interop needs JDK-17 support first!
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
May 11, 2023
Java.Interop needs JDK-17 support first!
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
May 12, 2023
Java.Interop needs JDK-17 support first!
Use Gradle 8.1.1, fix `build.gradle` so it works with Gradle 8.1.1.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
May 12, 2023
Java.Interop needs JDK-17 support first!
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
May 12, 2023
Java.Interop needs JDK-17 support first!
JdkInfo.props rename strikes again!
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
May 12, 2023
Java.Interop needs JDK-17 support first!
Looks like tools/java-source-utils tests still require JDK 1.8 to pass on CI?
jonpryor
force-pushed
the
jonp-allow-jdk-17
branch
from
May 12, 2023 23:47
7de05e6
to
30c41f9
Compare
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
May 12, 2023
Java.Interop needs JDK-17 support first!
"Random *argh!*s"
|
`<SetEnvironmentVariable/>` was failing because `JI_JVM_PATH` was being set to an empty string.
jonpryor
force-pushed
the
jonp-allow-jdk-17
branch
from
May 13, 2023 00:13
4d69b72
to
cb29a4b
Compare
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
May 13, 2023
Superseded by PR #1141. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#8029
Update
<JdkInfo/>
task to emit a new$(Java*MajorVersion)
MSBuild property. This is used bysrc/Java.Base
so that it knows which JDK version it's binding.Begin explicitly qualifying all
$(Jdk*)
and$(Java*)
MSBuild properties to explicitly disambiguate between JDK 1.8 and JDK-11 contexts. Eventually we may "swap" things so that properties without a version are for e.g. JDK 11 (17, etc.) and$(Jdk8*)
is for JDK 1.8-requiring contexts.Note: to get this to build we had to update
src/Java.Base
to support binding against JDK-17, which was an expected diversion. This "JDK-17 Java.Base binding" was a "time limited" effort.