Revert "Change behavior of copy action to not rewrite assemblies" #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit 1d96189.
|
Also worth noting that System.Runtime.CompilationServices.Unsafe was one of the things keeping the dependency on System.Runtime (the other being the app itself). Marking it IsTrimmable will probably shave more size off System.Runtime. |
sbomer
approved these changes
Apr 1, 2021
|
Makes sense (I didn't know about that so sorry for the extra work) |
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
…tnet/linker#1936) This reverts commit dotnet/linker@1d96189. Commit migrated from dotnet/linker@e754a0a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1869
Reverting from now. I'm still working on an edge case that I found while linking a blazorwasm app just after
System.Runtime.CompilationServices.Unsafewas marked asIsTrimmable: custom attributes having enum arguments living in assemblies that are forwarded seem to have problems -- so far, I've been able to circumvent this by marking the forwarded scopes of CAs arguments, but I still need to add appropriate tests and measure impact with this changes.