Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Page API docs #16981

Merged
merged 7 commits into from
Sep 7, 2023
Merged

Update Page API docs #16981

merged 7 commits into from
Sep 7, 2023

Conversation

jfversluis
Copy link
Member

Description of Change

Moves the external comments to inline, adds missing comments and minor improvements.

Issues Fixed

Related to #3960

@jfversluis jfversluis added area-docs Conceptual docs, API docs, Samples t/housekeeping ♻︎ labels Aug 24, 2023
@jfversluis jfversluis requested a review from a team as a code owner August 24, 2023 14:12
@jfversluis jfversluis enabled auto-merge (squash) August 24, 2023 14:12
src/Controls/src/Core/Page/Page.cs Outdated Show resolved Hide resolved
src/Controls/src/Core/Page/Page.cs Outdated Show resolved Hide resolved
src/Controls/src/Core/Page/Page.cs Outdated Show resolved Hide resolved
src/Controls/src/Core/Page/Page.cs Outdated Show resolved Hide resolved
src/Controls/src/Core/Page/Page.cs Outdated Show resolved Hide resolved
src/Controls/src/Core/Page/Page.cs Outdated Show resolved Hide resolved
src/Controls/src/Core/Page/Page.cs Outdated Show resolved Hide resolved
src/Controls/src/Core/Page/Page.cs Outdated Show resolved Hide resolved
src/Controls/src/Core/Page/Page.cs Outdated Show resolved Hide resolved
src/Controls/src/Core/Page/Page.cs Outdated Show resolved Hide resolved
jknaudt21
jknaudt21 previously approved these changes Aug 29, 2023
@samhouts samhouts added this to the .NET 8 GA milestone Aug 29, 2023
src/Controls/src/Core/Page/Page.cs Outdated Show resolved Hide resolved
src/Controls/src/Core/Page/Page.cs Outdated Show resolved Hide resolved
src/Controls/src/Core/Page/Page.cs Outdated Show resolved Hide resolved
src/Controls/src/Core/Page/Page.cs Outdated Show resolved Hide resolved
@rmarinho rmarinho requested review from jknaudt21 and davidbritch and removed request for jsuarezruiz September 1, 2023 14:03
@jfversluis jfversluis merged commit b1729b3 into main Sep 7, 2023
38 checks passed
@jfversluis jfversluis deleted the page-api-docs branch September 7, 2023 17:51
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
@samhouts samhouts added the fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-docs Conceptual docs, API docs, Samples fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373! t/housekeeping ♻︎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants