-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Page API docs #16981
Merged
Merged
Update Page API docs #16981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jknaudt21
requested changes
Aug 24, 2023
Co-authored-by: Juan Diego Herrera <[email protected]>
jknaudt21
previously approved these changes
Aug 29, 2023
samhouts
requested changes
Aug 30, 2023
Co-authored-by: Samantha Houts <[email protected]>
Co-authored-by: Samantha Houts <[email protected]>
rmarinho
requested review from
jknaudt21 and
davidbritch
and removed request for
jsuarezruiz
September 1, 2023 14:03
jknaudt21
approved these changes
Sep 1, 2023
samhouts
approved these changes
Sep 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-docs
Conceptual docs, API docs, Samples
fixed-in-8.0.0-rc.2.9373
Look for this fix in 8.0.0-rc.2.9373!
t/housekeeping ♻︎
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Moves the external comments to inline, adds missing comments and minor improvements.
Issues Fixed
Related to #3960