[iOS] Use updated APIs for the button with images #20953

tj-devel709 · 2024-03-01T21:56:56Z

Description of Change

~~Cherry pick iOS only changes from #19834~~
This PR updates a deprecated API in iOS to use the newer UIButton.Configuration API. Resizing is not really an option anymore with the new API and requires creating a new image each time. For now, let's update to the new API.

Issues Fixed

Makes progress towards #9734
Makes progress towards #21394

tj-devel709 · 2024-03-01T21:58:38Z

Bringing over this comment:

It appears that there is an issue on iOS with an ImageButton inside a scrollview. The image does not resize with the width request as android and Windows does. Check out the bottom imagebutton in each of the screenshots:

iOS:

Android:

Windows:

This is the relevant xaml:

<ScrollView HeightRequest="100" WidthRequest="50">
   <ImageButton Source="dotnet_bot.png" />
</ScrollView>

jsuarezruiz · 2024-03-04T14:32:10Z

Bringing over this comment:

It appears that there is an issue on iOS with an ImageButton inside a scrollview. The image does not resize with the width request as android and Windows does. Check out the bottom imagebutton in each of the screenshots:

iOS:

Android:

Windows:

This is the relevant xaml:
<ScrollView HeightRequest="100" WidthRequest="50">
   <ImageButton Source="dotnet_bot.png" />
</ScrollView>

Could we move ResizeImageSource extension method to the ButtonExtensions and then, use the same on the ImageButtonImageSourcePartSetter from ButtonHandler and ImageButtonHandler?

dotnet-policy-service · 2024-03-11T23:51:27Z

1 file(s) have code issues.

File	Issues
`.github/policies_readme.md`	Exception during deserialization. Invalid cast from 'System.String' to 'GitOps.Primitives.Abstractions.ConfigAsCode'.

_{Total execution time: 0.00 seconds}

…18242

…i for now

This reverts commit a0e0b0e.

jsuarezruiz

Is the first Button behavior an expected result?

jsuarezruiz · 2024-03-22T10:42:12Z

src/Controls/samples/Controls.Sample.UITests/Issues/Issue18242.xaml.cs

@@ -4,7 +4,7 @@
 namespace Maui.Controls.Sample.Issues
 {
 	[XamlCompilation(XamlCompilationOptions.Compile)]
-	[Issue(IssueTracker.Github, 18242, "Button ImageSource not Scaling as expected", PlatformAffected.UWP)]
+	[Issue(IssueTracker.Github, 18242, "Button ImageSource not Scaling as expected", PlatformAffected.All)]


Could we include here a sample using a different ContentLayout (for example, Top)?
Could we include a case using dynamic size?. We can include a button, and tapping it just increase at runtime the height using a random value.

tj-devel709 · 2024-03-22T18:21:52Z

Since this PR is not addressing resizing, removed the existing UITest for iOS that was testing resizing and instead added a UITest with a screenshot test to make sure the different image placements work with the button. Will wait for the UITest to produce the diffs!

jsuarezruiz · 2024-03-25T10:06:31Z

src/Controls/tests/UITests/Tests/Issues/Issue21394.cs

+
+			App.WaitForElement("WaitForStubControl");
+
+			VerifyScreenshot();


The snapshots for Android and Windows are pending.

tj-devel709 · 2024-03-25T18:26:30Z

The windows screenshot is looking a little funky. Testing on windows

PureWeen · 2024-03-27T19:16:21Z

Possibly related
#21488

* Ensure images in buttons never scale up, only down * Use `GetImageSourceSize` * Port UI tests from #20953 * Ensure max height is reset Ensure source is set after image opened event is subscribed to --------- Co-authored-by: Mike Corsaro <[email protected]>

tj-devel709 · 2024-09-06T17:11:25Z

Closing for now until coming back to this one!

tj-devel709 added platform/iOS 🍎 legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor area-controls-button Button, ImageButton labels Mar 1, 2024

tj-devel709 changed the title ~~Dev/tj/i os18242~~ [iOS] Fix image button scaling Mar 1, 2024

jsuarezruiz self-requested a review March 4, 2024 12:48

jsuarezruiz mentioned this pull request Mar 4, 2024

[Android] Correctly scale Button image #19834

Merged

jsuarezruiz mentioned this pull request Mar 6, 2024

[Catalyst] Fix Image not rendering in Mac Idiom (Device family = 6) Button #21048

Closed

tj-devel709 changed the base branch from main to release/8.0.1xx-sr3 March 6, 2024 18:39

tj-devel709 force-pushed the dev/TJ/iOS18242 branch from 395da71 to c051eb7 Compare March 6, 2024 18:50

tj-devel709 marked this pull request as ready for review March 6, 2024 18:50

tj-devel709 requested a review from a team as a code owner March 6, 2024 18:50

tj-devel709 requested review from rmarinho and removed request for a team March 6, 2024 18:50

tj-devel709 marked this pull request as draft March 7, 2024 15:56

tj-devel709 force-pushed the dev/TJ/iOS18242 branch 2 times, most recently from e5aec15 to b4d09d9 Compare March 11, 2024 23:51

tj-devel709 changed the base branch from release/8.0.1xx-sr3 to main March 11, 2024 23:51

Move the iOS code and implement the changes for iOS15 plus.

e01061e

tj-devel709 force-pushed the dev/TJ/iOS18242 branch from becfb16 to e01061e Compare March 12, 2024 00:14

tj-devel709 and others added 8 commits March 13, 2024 23:35

more ios 15 plus api work

a0b1e73

See if we need to resize the buttons in top and bottom placements

c4af554

Merge branch 'main' into dev/TJ/iOS18242

f1bb457

apply the correct image spacing

fbb83a8

Merge remote-tracking branch 'origin/dev/TJ/iOS18242' into dev/TJ/iOS…

62d01be

…18242

Adjust the padding code for 15 plus

d6e7f52

remove unused code

e9e4d2b

set the configs more consistently

331cb66

tj-devel709 marked this pull request as ready for review March 21, 2024 19:52

tj-devel709 added 4 commits March 21, 2024 15:17

revert imagebutton changes and allow imagebutton to use deprecated ap…

7d435fa

…i for now

Add the resizing code for iOS 15 plus

a0e0b0e

move the UpdateContentLayout to the handler

20f286a

Revert "Add the resizing code for iOS 15 plus"

f80c0cb

This reverts commit a0e0b0e.

jsuarezruiz reviewed Mar 22, 2024

View reviewed changes

tj-devel709 changed the title ~~[iOS] Fix image button scaling~~ [iOS] Use updated APIs for the button with images Mar 22, 2024

add a UITest with Screenshot

141c364

jsuarezruiz reviewed Mar 25, 2024

View reviewed changes

add ios and android images and change test conditional

bafa5c4

tj-devel709 and others added 4 commits March 25, 2024 14:00

remove windows from test and use core UpdateText

df9a1f6

ignore test on windows

2b6f230

- CS fixes

e70269c

- small fix

3297c57

Foda mentioned this pull request Mar 26, 2024

[Windows] Ensure images in buttons never scale up, only down #21463

Merged

tj-devel709 added 2 commits March 26, 2024 18:21

character spacing and font mostly working

e4eb827

add the ios screenshot

07b157c

tj-devel709 marked this pull request as draft March 26, 2024 23:22

PureWeen mentioned this pull request Mar 27, 2024

[iOS] Button CharacterSpacing Fix #20537

Open

Foda pushed a commit that referenced this pull request Mar 27, 2024

Port UI tests from #20953

4f9c994

add compatibility for ios 14 and below and do resizing for both

efed01c

tj-devel709 mentioned this pull request Apr 10, 2024

[iOS] Allow compat iOS buttons to resize image and to respect spacing and padding #21759

Merged

Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024

tj-devel709 closed this Sep 6, 2024

github-actions bot locked and limited conversation to collaborators Oct 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[iOS] Use updated APIs for the button with images #20953

[iOS] Use updated APIs for the button with images #20953

tj-devel709 commented Mar 1, 2024 •

edited

Loading

tj-devel709 commented Mar 1, 2024

jsuarezruiz commented Mar 4, 2024

dotnet-policy-service bot commented Mar 11, 2024

jsuarezruiz left a comment

jsuarezruiz Mar 22, 2024

tj-devel709 commented Mar 22, 2024

jsuarezruiz Mar 25, 2024

tj-devel709 commented Mar 25, 2024

PureWeen commented Mar 27, 2024

tj-devel709 commented Sep 6, 2024


		App.WaitForElement("WaitForStubControl");

		VerifyScreenshot();

[iOS] Use updated APIs for the button with images #20953

[iOS] Use updated APIs for the button with images #20953

Conversation

tj-devel709 commented Mar 1, 2024 • edited Loading

Description of Change

Issues Fixed

tj-devel709 commented Mar 1, 2024

jsuarezruiz commented Mar 4, 2024

dotnet-policy-service bot commented Mar 11, 2024

jsuarezruiz left a comment

Choose a reason for hiding this comment

jsuarezruiz Mar 22, 2024

Choose a reason for hiding this comment

tj-devel709 commented Mar 22, 2024

jsuarezruiz Mar 25, 2024

Choose a reason for hiding this comment

tj-devel709 commented Mar 25, 2024

PureWeen commented Mar 27, 2024

tj-devel709 commented Sep 6, 2024

tj-devel709 commented Mar 1, 2024 •

edited

Loading