[Android] Fix flyout behaviour switching exception #22453

imuller · 2024-05-16T13:15:38Z

Description of Change

Two issues where fixed in this PR:

When you change the FlyoutBehavior the app crashes
When you change the orientation on a tablet from portrait to landscape with the flyout open, the app crashes. Because the FlyoutBehavior changes

Issues Fixed

Fixes #20858
Fixes #18161

jsuarezruiz · 2024-05-16T17:05:49Z

/azp run

azure-pipelines · 2024-05-16T17:06:10Z

Azure Pipelines successfully started running 3 pipeline(s).

imuller · 2024-05-17T12:01:54Z

What to do with these failing tests?

PureWeen · 2024-05-17T21:00:12Z

@imuller can you add UITests to this?

Here's an example
https://github.com/dotnet/maui/pull/22492/files
Here are some docs with info how to get the right bits installed
https://github.com/dotnet/maui/wiki/UITests

imuller · 2024-05-19T16:09:48Z

@PureWeen Can you check the added tests

jsuarezruiz · 2024-05-20T14:17:57Z

/azp run

azure-pipelines · 2024-05-20T14:18:16Z

Azure Pipelines successfully started running 3 pipeline(s).

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20858.cs

jsuarezruiz · 2024-05-22T11:39:53Z

/azp run

azure-pipelines · 2024-05-22T11:40:13Z

Azure Pipelines successfully started running 3 pipeline(s).

imuller · 2024-05-27T06:46:23Z

@jsuarezruiz Any idea why these tests are failing?

imuller · 2024-06-03T08:56:58Z

@jsuarezruiz @PureWeen When will this PR get approval?

jsuarezruiz · 2024-06-11T13:46:50Z

/azp run

azure-pipelines · 2024-06-11T13:47:13Z

Azure Pipelines successfully started running 3 pipeline(s).

imuller · 2024-06-12T08:13:32Z

@jsuarezruiz Can you re-run the tests. Should be fixed now.

jsuarezruiz · 2024-06-12T15:38:49Z

/azp run

azure-pipelines · 2024-06-12T15:39:12Z

Azure Pipelines successfully started running 3 pipeline(s).

imuller · 2024-06-12T21:38:38Z

@jsuarezruiz @jfversluis It looks like other tests are failing, that does not has to do anything with this PR. What to do in this case?

jsuarezruiz · 2024-06-13T11:46:21Z

@jsuarezruiz @jfversluis It looks like other tests are failing, that does not has to do anything with this PR. What to do in this case?

The added test is failing on Android and iOS, could you check it? Here the trace:

 at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 804
   at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 821
   at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 316
   at Microsoft.Maui.TestCases.Tests.Issues.Issue20858.NoExceptionShouldBeThrown() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20858.cs:line 21
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)

Let me know if can help with anything :)

jsuarezruiz

The change to fix the issue have sense to me, just the test seems to be failing. Could you take a look? Or just let me know if want me to take a look to it.

imuller · 2024-06-13T12:13:57Z

@jsuarezruiz If possible, can you take a look at the test? It's not clear to me why it's failing.

azure-pipelines · 2024-06-18T19:06:29Z

Azure Pipelines successfully started running 3 pipeline(s).

Redth · 2024-06-21T18:23:56Z

/azp run

azure-pipelines · 2024-06-21T18:24:16Z

Azure Pipelines successfully started running 3 pipeline(s).

PureWeen · 2024-06-24T22:41:21Z

/azp run

azure-pipelines · 2024-06-24T22:41:40Z

Azure Pipelines successfully started running 3 pipeline(s).

jfversluis

Congratulations, you are now a contributor to .NET MAUI! Thank you for your efforts on this and the great collaboration!

Approved by 3 others and remarks have been fixed

* Simplify Development.md (#23142) * Simplify Development.md * Update .github/DEVELOPMENT.md Co-authored-by: Eilon Lipton <[email protected]> * Update .github/DEVELOPMENT.md Co-authored-by: Eilon Lipton <[email protected]> * Update .github/DEVELOPMENT.md Co-authored-by: Eilon Lipton <[email protected]> * Update .github/DEVELOPMENT.md Co-authored-by: Eilon Lipton <[email protected]> * Update DEVELOPMENT.md * - modify and move advanced tips to different file * Update DEVELOPMENT.md * Update .github/DEVELOPMENT.md Co-authored-by: Gerald Versluis <[email protected]> * Update docs/DevelopmentTips.md Co-authored-by: Gerald Versluis <[email protected]> * Update docs/DevelopmentTips.md Co-authored-by: Gerald Versluis <[email protected]> * - updates based on review --------- Co-authored-by: Eilon Lipton <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> * Wire RefreshView up to our xplat layout workflow (#23169) (#23218) * Use better layout/measure path with refreshview * - fix naming * - set RefreshView content to maui compatible container * - add test * - fix null operator * Update Issue23029.xaml.cs * - fix content panel so it removes previous content * - add additional check * Remove adding to FutureAccessList as the app is running with runFullTrust capability (#23047) * Call base.OnResume if Existing NavigationFragment Early (#23187) * VSCode no longer uses MAUI to launch (#23222) * [Android] Fix flyout behaviour switching exception (#22453) * Fix flyout behaviour switching exception * Tests added * Flyout test page added * Flyoutpage test fixes * Flyout toggle test added * Remove duplicate ] characters * Flyout test pages added * Check for platforms * Fix title * - fix tests --------- Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Shane Neuville <[email protected]> * Renamed the project because macOS uses .app (#23223) * Renamed the project because macOS uses .app * And the folder * merge first * ns * Move tests to new location (#23251) * Split SingleProject targets (#23269) * Split SingleProject targets * Update Microsoft.Maui.Controls.SingleProject.Before.targets * Update bug-report.yml with 8.0.61 (#23273) * Null terminate Page on TabbedRenderer (#23290) Co-authored-by: Shane Neuville <[email protected]> * [Windows] Improve performance in accessibility extensions (#22698) * AccessibilityExtensions: Add missing braces * AccessibilityExtensions: Enable nullability and improve performance * Update shipped & unshipped API --------- Co-authored-by: Javier Suárez <[email protected]> * [Android] Avoid double event subscribes in gesture manager (#23242) * [Android] Avoid double event subscribes in gesture manager * Fix typo in test text * Bump Microsoft.Web.WebView2 from 1.0.2151.40 to 1.0.2592.51 (#23209) * [tests] test a lot more things in `MemoryTests.cs` (#23324) * [tests] test a lot more things in `MemoryTests.cs` This expands the tests to cover more controls and areas. * Add test cases for more controls: * `Ellipse` * `Grid` * `Path` * `Line` * `Path` * `RadioButton` * `Rectangle` * `RoundRectangle` * Expand tests for a couple controls: * `Border` has a `StrokeShape` * Any `TemplatedView` gets a `ControlTemplate` * Re-enable `ListView` for Android This should work now after merging: * dotnet/android#8900 * #23120 * Add a complicated test case for `BindableLayout` Similar to the case at: * #23199 * Skip `ListView` on API 23 * Bump Appium version to 2.11 (#23337) * Bump Appium version to 2.11 * Update CarouselViewUITests.UpdateCurrentItem.cs * Update appium-install.ps1 * Update CarouselViewUITests.UpdateCurrentItem.cs * Simplify `NavigationRootManager.Connect` on the Windows platform. (#23345) * Simplify `NavigationRootManager.Connect` on the Windows platform. * Use ternary operator syntax * Removed extra tabs * Moved `_disconnected = false;` to `if (_disconnected)` * Bump Appium Drivers (#23349) * Fix Merge --------- Co-authored-by: Eilon Lipton <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: MartyIX <[email protected]> Co-authored-by: Matthew Leibowitz <[email protected]> Co-authored-by: Thomas Muller <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Jonathan Dick <[email protected]> Co-authored-by: Jonathan Peppers <[email protected]> Co-authored-by: Takym (たかやま) <[email protected]>

imuller requested a review from a team as a code owner May 16, 2024 13:15

imuller requested review from PureWeen and jsuarezruiz May 16, 2024 13:15

dotnet-policy-service bot added the community ✨ Community Contribution label May 16, 2024

jsuarezruiz added platform/android 🤖 area-controls-flyout Flyout labels May 17, 2024

jsuarezruiz previously requested changes May 21, 2024

View reviewed changes

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20858.cs Outdated Show resolved Hide resolved

imuller requested a review from jsuarezruiz May 28, 2024 20:45

dotnet deleted a comment from azure-pipelines bot Jun 11, 2024

jsuarezruiz reviewed Jun 13, 2024

View reviewed changes

Fix flyout behaviour switching exception

823663e

imuller and others added 8 commits June 18, 2024 20:56

Tests added

75e9fd2

Flyout test page added

8d590db

Flyoutpage test fixes

1c2b745

Flyout toggle test added

7e5b16b

Remove duplicate ] characters

c4fe537

Flyout test pages added

819b4cf

Check for platforms

fcdcf5c

Fix title

0e81ec1

jfversluis force-pushed the fix-20858-and-18161 branch from 61c4321 to 0e81ec1 Compare June 18, 2024 19:05

imuller requested a review from jsuarezruiz June 19, 2024 11:25

- fix tests

9bdd4c3

PureWeen previously approved these changes Jun 21, 2024

View reviewed changes

Redth previously approved these changes Jun 21, 2024

View reviewed changes

PureWeen enabled auto-merge (squash) June 21, 2024 18:26

- fix for WinUI

2725fe5

PureWeen dismissed stale reviews from Redth and themself via 2725fe5 June 24, 2024 22:40

jfversluis approved these changes Jun 25, 2024

View reviewed changes

PureWeen merged commit 1750736 into dotnet:main Jun 25, 2024
47 checks passed

imuller deleted the fix-20858-and-18161 branch June 25, 2024 09:00

github-actions bot locked and limited conversation to collaborators Jul 26, 2024

samhouts added fixed-in-8.0.70 fixed-in-net9.0-nightly This may be available in a nightly release! labels Aug 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Android] Fix flyout behaviour switching exception #22453

[Android] Fix flyout behaviour switching exception #22453

imuller commented May 16, 2024 •

edited by jfversluis

Loading

jsuarezruiz commented May 16, 2024

azure-pipelines bot commented May 16, 2024

imuller commented May 17, 2024

PureWeen commented May 17, 2024

imuller commented May 19, 2024

jsuarezruiz commented May 20, 2024

azure-pipelines bot commented May 20, 2024

jsuarezruiz commented May 22, 2024

azure-pipelines bot commented May 22, 2024

imuller commented May 27, 2024

imuller commented Jun 3, 2024

jsuarezruiz commented Jun 11, 2024

azure-pipelines bot commented Jun 11, 2024

imuller commented Jun 12, 2024

jsuarezruiz commented Jun 12, 2024 •

edited by jfversluis

Loading

azure-pipelines bot commented Jun 12, 2024

imuller commented Jun 12, 2024

jsuarezruiz commented Jun 13, 2024

jsuarezruiz left a comment

imuller commented Jun 13, 2024 •

edited

Loading

azure-pipelines bot commented Jun 18, 2024

Redth commented Jun 21, 2024

azure-pipelines bot commented Jun 21, 2024

PureWeen commented Jun 24, 2024

azure-pipelines bot commented Jun 24, 2024

jfversluis left a comment

[Android] Fix flyout behaviour switching exception #22453

[Android] Fix flyout behaviour switching exception #22453

Conversation

imuller commented May 16, 2024 • edited by jfversluis Loading

Description of Change

Issues Fixed

jsuarezruiz commented May 16, 2024

azure-pipelines bot commented May 16, 2024

imuller commented May 17, 2024

PureWeen commented May 17, 2024

imuller commented May 19, 2024

jsuarezruiz commented May 20, 2024

azure-pipelines bot commented May 20, 2024

jsuarezruiz commented May 22, 2024

azure-pipelines bot commented May 22, 2024

imuller commented May 27, 2024

imuller commented Jun 3, 2024

jsuarezruiz commented Jun 11, 2024

azure-pipelines bot commented Jun 11, 2024

imuller commented Jun 12, 2024

jsuarezruiz commented Jun 12, 2024 • edited by jfversluis Loading

azure-pipelines bot commented Jun 12, 2024

imuller commented Jun 12, 2024

jsuarezruiz commented Jun 13, 2024

jsuarezruiz left a comment

Choose a reason for hiding this comment

imuller commented Jun 13, 2024 • edited Loading

azure-pipelines bot commented Jun 18, 2024

Redth commented Jun 21, 2024

azure-pipelines bot commented Jun 21, 2024

PureWeen commented Jun 24, 2024

azure-pipelines bot commented Jun 24, 2024

jfversluis left a comment

Choose a reason for hiding this comment

imuller commented May 16, 2024 •

edited by jfversluis

Loading

jsuarezruiz commented Jun 12, 2024 •

edited by jfversluis

Loading

imuller commented Jun 13, 2024 •

edited

Loading