Revert "[X] do not apply Bindings if DataType doesnt match (#22056)" #24049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cb0a332. # Conflicts: # src/Controls/src/Core/Binding.cs # src/Controls/src/Xaml/MarkupExtensions/BindingExtension.cs # src/Controls/src/Xaml/XamlServiceProvider.cs
PureWeen
requested review from
Eilon,
StephaneDelcroix and
mattleibow
and removed request for
a team and
Eilon
|
@PureWeen do we get a binding warning that this binding is trying to be compiled, but unable to be compiled and thus falling back to this behavior? |
mattleibow
added a commit
that referenced
this pull request
Aug 7, 2024
mattleibow
added a commit
that referenced
this pull request
Aug 8, 2024
samhouts
added
the
fixed-in-net9.0-nightly
samhouts
added
the
fixed-in-net8.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Before
After
This reverts commit cb0a332.
It caused the following regression
#23989