[XC] Fix passing message arguments to BuildException when logging warning as error #25151
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDelcroix
previously approved these changes
Oct 9, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
The failing tests don't seem related. |
StephaneDelcroix
approved these changes
Oct 14, 2024
samhouts
added
the
fixed-in-net9.0-nightly
|
/backport to release/9.0.1xx |
|
Started backporting to release/9.0.1xx: https://github.com/dotnet/maui/actions/runs/11368120962 |
samhouts
added
fixed-in-9.0.10
and removed
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
We weren't passing
messageArgsto the constructor ofBuildException. In the case of warnings such as XC0045 the error message could not be correctly formatted because it expected multiple arguments and none were available./cc @StephaneDelcroix