[release/8.0.1xx-sr9] Fix Regression with iOS button resizing with text or image change #25214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tj-devel709
requested review from
mattleibow and
rmarinho
and removed request for
a team
tj-devel709
force-pushed
the
dev/TJ/ButtonTextChangeUpdate_backportToSR9
branch
from
8d96182 to
9f2a919
Compare
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
PureWeen
approved these changes
Oct 14, 2024
PureWeen
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR fixes a regression with iOS buttons re-updating the size of the button when the text changes. There was some code that was trying to use the UIButton.TitleLabel.Bounds for sizing, but there are times the TitleLabel is still set to the old title. This PR also allows changes to the button size when the image is changed.
Issues Fixed
Fixes #25074
Small demo showing changing text and images triggers a resize when needed. The small jump in animation was already there and is not new to this PR.
Screen.Recording.2024-10-07.at.4.01.35.PM.mov