Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update templates for non-VS IDE hosts #25303

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

smitpatel
Copy link
Contributor

Description of Change

List csproj files in primaryOutputs for maui blazor solution template

Issues Fixed

Fixes #22381

net9.0. I didn't find this template in main branch.

@smitpatel smitpatel requested review from a team as code owners October 15, 2024 21:49
Copy link
Contributor

Hey there @smitpatel! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jfversluis
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jfversluis
jfversluis previously approved these changes Oct 16, 2024
@jfversluis
Copy link
Member

jfversluis commented Oct 16, 2024

Looking at the rest of the templates I do see that not opening a file on VS was intentional (see #12756), do we show a Getting Started page for this template?

@Eilon @jknaudt21 @BethMassi

@jfversluis jfversluis added the area-templates Project templates, Item Templates for Blazor and MAUI label Oct 16, 2024
@smitpatel
Copy link
Contributor Author

@jfversluis - Updated PR to remove those changes. File opening post action has no impact on the original issue. So it can be updated (or not) separately.

Copy link
Member

@Eilon Eilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow nice! So it was a template authoring error all along. My bad!

And hi, Smit 😁

@Eilon
Copy link
Member

Eilon commented Oct 16, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfversluis jfversluis enabled auto-merge (squash) October 16, 2024 19:13
@jknaudt21
Copy link
Contributor

Do we show a Getting Started page for this template?

@jfversluis for VS we show the Overview Page on all projects that have the MauiSingleProject capability and not MauiBlazor.

Since this is in the maui-blazor folder, my assumption is that we don't show it here.

@jfversluis
Copy link
Member

Thanks @jknaudt21 lets merge this first and I'll double check and make that other change if needed

@jfversluis jfversluis merged commit a85cb01 into dotnet:net9.0 Oct 16, 2024
24 checks passed
@smitpatel smitpatel deleted the smit/templatefix branch October 16, 2024 22:23
@jfversluis
Copy link
Member

Actually it shows the Getting Started for ASP.NET it seems, probably because it picks up on the web project so thats fine

image

@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-templates Project templates, Item Templates for Blazor and MAUI community ✨ Community Contribution fixed-in-9.0.10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants