Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Size not calculated properly when invoking UseMauiCompatibility method in MauiProgram #25494

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

vishnumenon2684
Copy link
Contributor

@vishnumenon2684 vishnumenon2684 commented Oct 24, 2024

Root Cause

When using UseMauiCompatibility, the ContentView handler is set to RenderToHandlerShim instead of ContentViewHandler. As a result, the measuring logic is managed by VisualElementRender, leading to a size of 0 being returned.

Description of Change

Registering the ContentView handler with the control as ContentView instead of IContentView will resolve the issue.

Validated the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Issues Fixed

Fixes #10238

Output

Windows

Before
Before

After
After

@vishnumenon2684 vishnumenon2684 requested a review from a team as a code owner October 24, 2024 07:14
@vishnumenon2684 vishnumenon2684 requested review from Eilon and StephaneDelcroix and removed request for a team October 24, 2024 07:14
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Oct 24, 2024
Copy link
Contributor

Hey there @vishnumenon2684! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@vishnumenon2684 vishnumenon2684 changed the title Fixed Size not calculated properly when invoking UseMauiCompatibility… Fixed Size not calculated properly when invoking UseMauiCompatibility method in MauiProgram Oct 24, 2024
@jsuarezruiz jsuarezruiz added the area-compatibility Issues related to features in the Compatibility Nuget label Oct 24, 2024
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@PureWeen PureWeen merged commit 505d0fc into dotnet:release/9.0.1xx Oct 24, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2024
@sheiksyedm sheiksyedm added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 6, 2024
@samhouts samhouts added fixed-in-9.0.0 fixed-in-net8.0-nightly This may be available in a nightly release! labels Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-compatibility Issues related to features in the Compatibility Nuget community ✨ Community Contribution fixed-in-9.0.0 fixed-in-net8.0-nightly This may be available in a nightly release! partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants