Skip invalidation on propagation #25652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
force-pushed
the
skip_invalidation_on_propagation
branch
from
56246f4 to
0afbdca
Compare
The depth is just there so each call knows how far down the tree the element that triggered the invalidation is and then it can make decisions about it Each depth is a throwaway value that just starts over when a new invalidation path is called. The motivation here is that if an element is 4 levels down from a scrollview we don't want that bubbling up to a forced invalidation of the platform element. It's just meant to be informative and then scroll view can decide if it wants to invalidate or not. Thats basically how it's worked in Maui up until 8.0.90 and then that regressed slightly and this pr fixes that regression |
StephaneDelcroix
approved these changes
Nov 4, 2024
|
PureWeen
added a commit
that referenced
this pull request
Nov 5, 2024
* Skip Invalidation unless you're my immediate child * - fix override on test * Fix Legacy Layouts Invalidation Propagation * - use invalidation args to propagate depth # Conflicts: # src/Controls/src/Core/Page/Page.cs # src/Controls/src/Core/VisualElement/VisualElement.cs
PureWeen
added a commit
that referenced
this pull request
Nov 6, 2024
* Skip invalidation on propagation (#25652) * Skip Invalidation unless you're my immediate child * - fix override on test * Fix Legacy Layouts Invalidation Propagation * - use invalidation args to propagate depth # Conflicts: # src/Controls/src/Core/Page/Page.cs # src/Controls/src/Core/VisualElement/VisualElement.cs * - fix up UseLegacyMeasureInvalidatedBehaviorEnabled * - fix missing NS * - add test * - add screen shots * - snapshots * - final snapshots
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main purpose of #23052 was to propagate the MeasureInvalidated event up the tree. The problem with doing this is that the
Pageand theCompatibility.Layoutwill fireInvalidateMeasurewhen that propagation gets to them.This PR shift the needle back a little bit and only fires those paths if the invalidation is fired from a direct child. We still want the event to propagate up the tree for listeners to act on but we don't want anything beyond the immediate parent to invalidate