Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try not run on arm64 #25701

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Try not run on arm64 #25701

merged 3 commits into from
Nov 6, 2024

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Nov 6, 2024

Description of Change

try fix template tests

Fixes #25695

@rmarinho rmarinho requested a review from a team as a code owner November 6, 2024 00:42
@@ -7,7 +7,7 @@ public static class DotnetInternal
{
static readonly string DotnetRoot = Path.Combine(TestEnvironment.GetMauiDirectory(), ".dotnet");
static readonly string DotnetTool = Path.Combine(DotnetRoot, "dotnet");
const int DEFAULT_TIMEOUT = 900;
const int DEFAULT_TIMEOUT = 1800;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why requires to duplicate the default timeout time?

Copy link
Member Author

@rmarinho rmarinho Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BEcause we are hitting the time limit .

@rolfbjarne @dalexsoto i m not sure what follow up we need here, but seems that we a issue where this is slower on net9 , and takes mroe than 15 minutes to do a simple release run . We have see other people saying this is getting slower to do dotnet run on net9

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you get a binlog of something that runs fast in .NET 8 and slow in .NET 9 (so two binlogs - before and after)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok this is from the test failure timeout on net9 sample.binlog.zip

I m trying to get the same for net8, we didn't had logs for this on that branch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems it didn t work . 30 minutes it still hangs

@rmarinho rmarinho merged commit 27c4f79 into main Nov 6, 2024
65 of 96 checks passed
@rmarinho rmarinho deleted the fix-sample-tests branch November 6, 2024 23:22
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2024
@samhouts samhouts added fixed-in-9.0.10 fixed-in-net8.0-nightly This may be available in a nightly release! labels Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-9.0.10 fixed-in-net8.0-nightly This may be available in a nightly release!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[testing] Some builds hang when running iOS samples or template tests
5 participants