Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Fix FlyoutPage ShouldShowToolbarButton when overridden to return false, still shows button in title bar #25857

Merged
merged 5 commits into from
Jan 10, 2025

Added-Windows-SnapShot

87afa4a
Select commit
Loading
Failed to load commit list.
Merged

[Windows] Fix FlyoutPage ShouldShowToolbarButton when overridden to return false, still shows button in title bar #25857

Added-Windows-SnapShot
87afa4a
Select commit
Loading
Failed to load commit list.
Azure Pipelines / MAUI-UITests-public succeeded Nov 26, 2024 in 19m 26s

Build #9.0.10-ci+pr.25857.azdo.128945 had test failures

Details

Tests

  • Failed: 8 (0.32%)
  • Passed: 1,812 (71.59%)
  • Other: 711 (28.09%)
  • Total: 2,531

Annotations

Check failure on line 713 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Build log #L713

PowerShell exited with code '1'.

Check failure on line 626 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Build log #L626

PowerShell exited with code '1'.

Check failure on line 666 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Build log #L666

PowerShell exited with code '1'.

Check failure on line 581 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Build log #L581

PowerShell exited with code '1'.

Check failure on line 1 in Microsoft.Maui.TestCases.Tests.Issues.Issue23158(Android).ValidateEntryClearButtonVisibilityBehavior

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Microsoft.Maui.TestCases.Tests.Issues.Issue23158(Android).ValidateEntryClearButtonVisibilityBehavior

VisualTestUtils.VisualTestFailedException : 
Snapshot different than baseline: ValidateEntryClearButtonVisibilityBehavior.png (1.59% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.

More info: https://aka.ms/visual-test-workflow
Raw output
   at VisualTestUtils.VisualRegressionTester.Fail(String message)
   at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext)
   at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|7_0(String name) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 235
   at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 117
   at Microsoft.Maui.TestCases.Tests.Issues.Issue23158.ValidateEntryClearButtonVisibilityBehavior() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue23158.cs:line 28
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 1 in Microsoft.Maui.TestCases.Tests.Issues.Issue19152(Android).EntryClearButtonColorShouldMatchTextColor

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Microsoft.Maui.TestCases.Tests.Issues.Issue19152(Android).EntryClearButtonColorShouldMatchTextColor

VisualTestUtils.VisualTestFailedException : 
Snapshot different than baseline: EntryClearButtonColorShouldMatchTextColor.png (1.05% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.

More info: https://aka.ms/visual-test-workflow
Raw output
   at VisualTestUtils.VisualRegressionTester.Fail(String message)
   at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext)
   at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|7_0(String name) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 235
   at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 117
   at Microsoft.Maui.TestCases.Tests.Issues.Issue19152.EntryClearButtonColorShouldMatchTextColor() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19152.cs:line 22
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 1 in Microsoft.Maui.TestCases.Tests.Issues.Issue18443(Android).EntrySelectionLengthRuntimeUpdate

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Microsoft.Maui.TestCases.Tests.Issues.Issue18443(Android).EntrySelectionLengthRuntimeUpdate

VisualTestUtils.VisualTestFailedException : 
Snapshot different than baseline: EntrySelectionLengthRuntimeUpdate.png (1.05% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.

More info: https://aka.ms/visual-test-workflow
Raw output
   at VisualTestUtils.VisualRegressionTester.Fail(String message)
   at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext)
   at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|7_0(String name) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 235
   at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 117
   at Microsoft.Maui.TestCases.Tests.Issues.Issue18443.EntrySelectionLengthRuntimeUpdate() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18443.cs:line 18
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 1 in Microsoft.Maui.TestCases.Tests.Issues.Issue12213(Android).TapGestureRecognizerNotWorkingOnEntry

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Microsoft.Maui.TestCases.Tests.Issues.Issue12213(Android).TapGestureRecognizerNotWorkingOnEntry

VisualTestUtils.VisualTestFailedException : 
Snapshot different than baseline: TapGestureRecognizerNotWorkingOnEntry.png (0.72% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.

More info: https://aka.ms/visual-test-workflow
Raw output
   at VisualTestUtils.VisualRegressionTester.Fail(String message)
   at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext)
   at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|7_0(String name) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 235
   at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 117
   at Microsoft.Maui.TestCases.Tests.Issues.Issue12213.TapGestureRecognizerNotWorkingOnEntry() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue12213.cs:line 23
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)