[Windows] Disable HitTest when showing EmptyView on CollectionView #26006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarinho
added
platform/windows 🪟
area-controls-collectionview
rmarinho
requested review from
Foda,
jsuarezruiz and
PureWeen
and removed request for
StephaneDelcroix and
jfversluis
jsuarezruiz
requested changes
Nov 21, 2024
|
|
||
| [Test] | ||
| [Category(UITestCategories.CollectionView)] | ||
| public void CanTapButtonOnEmptyView() |
There was a problem hiding this comment.
This test is failing on Android, iOS and Catalyst.
at Microsoft.Maui.TestCases.Tests.Issues.Issue19609.CanTapButtonOnEmptyView() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19609.cs:line 19
Could you check that the button is on the screen? You can use the timeout parameter to wait for one second for example.
There was a problem hiding this comment.
Hum seems the screenshot is on the previous screen?
but I have a waiterElement
App.WaitForElement("btnClick");
jsuarezruiz
approved these changes
Nov 27, 2024
samhouts
added
fixed-in-9.0.21
fixed-in-net8.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
On the the templates for
FormsListViewTemplatetheEmptyViewContentControlis bellow the ScrollViewer so it does t receive inputs even if no items are showing.Issues Fixed
Fixes #19609