Fixed CollectionViewHandler2 null reference exception if ItemsLayout is set for Tablet but not on mobile devices #26152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @NirmalKumarYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
NirmalKumarYuvaraj
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
approved these changes
Dec 4, 2024
NirmalKumarYuvaraj
added
the
partner/syncfusion
samhouts
added
fixed-in-9.0.21
fixed-in-net8.0-nightly
devanathan-vaithiyanathan
added a commit
to devanathan-vaithiyanathan/maui
that referenced
this pull request
Jan 8, 2025
…sLayout is set for Tablet but not on mobile devices (dotnet#26152)" This reverts commit 0ddc794.
devanathan-vaithiyanathan
added a commit
to devanathan-vaithiyanathan/maui
that referenced
this pull request
Jan 8, 2025
…msLayout is set for Tablet but not on mobile devices (dotnet#26152)" This reverts commit 4b9074c.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details
Adding a collectionview to a page and only setting the ItemsLayout property for Tablet will throw a null reference exception before the page appears on mobile.
Root Cause
At the time of wiring the ItemsLayout propertyChanged event the value for ItemsLayout is null. As a result , the exception is thrown.
Description of Change
Added a null check to ensure that the ItemsLayout property is not null before accessing it and wiring the event once the fallback value is set for ItemsLayout.
Validated the behaviour in the following platforms
Issues Fixed
Fixes #26065
Output