Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled DropEventCoordinates test for mobile platforms #26631

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

NirmalKumarYuvaraj
Copy link
Contributor

@NirmalKumarYuvaraj NirmalKumarYuvaraj commented Dec 14, 2024

Description of Change

I have enabled test cases to run on mobile platforms. However, Windows and Mac test cases are randomly failing on CI machines, even though they work properly on local machines.

Desktop platform Issue report : #26632

Issues Fixed

Fixes #26507

Output

Screenshot 2024-12-14 at 4 36 50 PM

Copy link
Contributor

Hey there @NirmalKumarYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Dec 14, 2024
@karthikraja-arumugam karthikraja-arumugam added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 14, 2024
@NirmalKumarYuvaraj NirmalKumarYuvaraj marked this pull request as ready for review December 14, 2024 12:19
@jfversluis
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jfversluis jfversluis added the area-testing Unit tests, device tests label Dec 16, 2024
@samhouts samhouts requested a review from Copilot December 16, 2024 19:39

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/Controls/tests/TestCases.Shared.Tests/Tests/DragAndDropUITests.cs:6

  • [nitpick] The variable name 'i' is ambiguous. It should be renamed to 'colonIndex' for better readability.
var i = labelText.IndexOf(':', StringComparison.Ordinal);
@jfversluis jfversluis merged commit d23790f into dotnet:main Dec 20, 2024
104 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reenable disabled UI tests
3 participants