Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update triggers in VS insertion pipelines #11037

Conversation

JanProvaznik
Copy link
Contributor

@JanProvaznik JanProvaznik commented Nov 25, 2024

Context

#10966
#10919
#10920
Without this change the scheduled runs on main inputs CI from any branch that had the last successful run which is wrong.

Notes for review

Desired functionality:

  1. Manually trigger from AzDO UI, ability to select as input resource pipeline a specific MSBuild CI run and specify to which branch to insert.
  2. Scheduled run on main every weekday inputting the last successful CI on main.
  3. Triggered runs after CI run finished in release branches (vs*)
  4. Ability to disable 2.,3. via AzDO UI by setting custom triggers and schedule.

Changes Made

Set schedules and triggers.
Changes logic to trigger servicing insertion on each commit to release branch.

Testing

Manually tested scenarios in a playground AzDO org.

  • Main last build, scheduled on main
  • release last build, scheduled on main
  • release last build, triggered by ci
  • multiple release branches - no double triggers
  • new release branch
  • manual run

@JanProvaznik JanProvaznik marked this pull request as ready for review November 26, 2024 13:38
@JanProvaznik JanProvaznik requested a review from a team November 26, 2024 13:40
@JanProvaznik JanProvaznik self-assigned this Nov 26, 2024
@JanProvaznik JanProvaznik merged commit 0b397a4 into dotnet:main Nov 29, 2024
10 checks passed
@JanProvaznik JanProvaznik deleted the dev/janpro/insertion-pipelines-separate-servicing branch November 29, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants